chrome/browser/extensions/api/management/chrome_management_api_delegate.h - Issue 1534123002: [Extensions] Migrate ExtensionInstallPrompt::Delegate to be a callback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/management/chrome_management_api_delegate.h

Issue 1534123002: [Extensions] Migrate ExtensionInstallPrompt::Delegate to be a callback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/developer_private/show_permissions_dialog_helper.cc ('k') | chrome/browser/extensions/api/management/chrome_management_api_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/management/chrome_management_api_delegate.h

diff --git a/chrome/browser/extensions/api/management/chrome_management_api_delegate.h b/chrome/browser/extensions/api/management/chrome_management_api_delegate.h

index 1c16eab76285a469645c6a71232e4d46a7a43454..73c417a6dffafa62b695e7714a1d2d9544fd48da 100644

--- a/chrome/browser/extensions/api/management/chrome_management_api_delegate.h

+++ b/chrome/browser/extensions/api/management/chrome_management_api_delegate.h

@@ -31,8 +31,10 @@ class ChromeManagementAPIDelegate : public extensions::ManagementAPIDelegate {

extensions::ManagementGetPermissionWarningsByManifestFunction* function,

const std::string& manifest_str) const override;

scoped_ptr<extensions::InstallPromptDelegate> SetEnabledFunctionDelegate(

- extensions::ManagementSetEnabledFunction* function,

- const extensions::Extension* extension) const override;

+ content::WebContents* web_contents,

+ content::BrowserContext* browser_context,

+ const extensions::Extension* extension,

+ const base::Callback<void(bool)>& callback) const override;

scoped_ptr<extensions::RequirementsChecker> CreateRequirementsChecker()

const override;

scoped_ptr<extensions::UninstallDialogDelegate> UninstallFunctionDelegate(