Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1315)

Unified Diff: chrome/browser/extensions/api/developer_private/show_permissions_dialog_helper.h

Issue 1534123002: [Extensions] Migrate ExtensionInstallPrompt::Delegate to be a callback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/developer_private/show_permissions_dialog_helper.h
diff --git a/chrome/browser/extensions/api/developer_private/show_permissions_dialog_helper.h b/chrome/browser/extensions/api/developer_private/show_permissions_dialog_helper.h
index 40bc916f8ae511390b40565454d71531ebac1bb4..aafd4683cd103def5e150f173a51c10021bc9cec 100644
--- a/chrome/browser/extensions/api/developer_private/show_permissions_dialog_helper.h
+++ b/chrome/browser/extensions/api/developer_private/show_permissions_dialog_helper.h
@@ -23,7 +23,7 @@ class Extension;
// Helper class to handle showing a permissions dialog for an extension. Will
// show either the newer AppInfo-style permissions dialog, or the traditional,
// install-prompt style dialog.
-class ShowPermissionsDialogHelper : public ExtensionInstallPrompt::Delegate {
+class ShowPermissionsDialogHelper {
public:
static void Show(content::BrowserContext* browser_context,
content::WebContents* web_contents,
@@ -34,15 +34,13 @@ class ShowPermissionsDialogHelper : public ExtensionInstallPrompt::Delegate {
private:
ShowPermissionsDialogHelper(Profile* profile,
const base::Closure& on_complete);
- ~ShowPermissionsDialogHelper() override; // Manages its own lifetime.
+ ~ShowPermissionsDialogHelper(); // Manages its own lifetime.
// Shows the old-style (not AppInfo) permissions dialog.
void ShowPermissionsDialog(content::WebContents* web_contents,
const Extension* extension);
- // ExtensionInstallPrompt::Delegate:
- void InstallUIProceed() override;
- void InstallUIAbort(bool user_initiated) override;
+ void OnInstallPromptDone(ExtensionInstallPrompt::Result result);
scoped_ptr<ExtensionInstallPrompt> prompt_;

Powered by Google App Engine
This is Rietveld 408576698