Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1164)

Unified Diff: chrome/browser/extensions/api/dashboard_private/dashboard_private_api.h

Issue 1534123002: [Extensions] Migrate ExtensionInstallPrompt::Delegate to be a callback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/api/dashboard_private/dashboard_private_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/dashboard_private/dashboard_private_api.h
diff --git a/chrome/browser/extensions/api/dashboard_private/dashboard_private_api.h b/chrome/browser/extensions/api/dashboard_private/dashboard_private_api.h
index d181966ccfd84ad2f803055496817f35098f9931..11e2da83c8fa5669a20284d4b07caf2dfa17a309 100644
--- a/chrome/browser/extensions/api/dashboard_private/dashboard_private_api.h
+++ b/chrome/browser/extensions/api/dashboard_private/dashboard_private_api.h
@@ -7,6 +7,7 @@
#include <string>
+#include "base/macros.h"
#include "base/memory/scoped_ptr.h"
#include "chrome/browser/bitmap_fetcher/bitmap_fetcher_delegate.h"
#include "chrome/browser/extensions/bundle_installer.h"
@@ -29,7 +30,6 @@ class Extension;
class DashboardPrivateShowPermissionPromptForDelegatedInstallFunction
: public UIThreadExtensionFunction,
- public ExtensionInstallPrompt::Delegate,
public WebstoreInstallHelper::Delegate {
public:
DECLARE_EXTENSION_FUNCTION(
@@ -55,9 +55,7 @@ class DashboardPrivateShowPermissionPromptForDelegatedInstallFunction
InstallHelperResultCode result,
const std::string& error_message) override;
- // ExtensionInstallPrompt::Delegate:
- void InstallUIProceed() override;
- void InstallUIAbort(bool user_initiated) override;
+ void OnInstallPromptDone(ExtensionInstallPrompt::Result result);
ExtensionFunction::ResponseValue BuildResponse(
api::dashboard_private::Result result,
@@ -74,6 +72,9 @@ class DashboardPrivateShowPermissionPromptForDelegatedInstallFunction
scoped_refptr<Extension> dummy_extension_;
scoped_ptr<ExtensionInstallPrompt> install_prompt_;
+
+ DISALLOW_COPY_AND_ASSIGN(
+ DashboardPrivateShowPermissionPromptForDelegatedInstallFunction);
};
class DashboardPrivateShowPermissionPromptForDelegatedBundleInstallFunction
« no previous file with comments | « no previous file | chrome/browser/extensions/api/dashboard_private/dashboard_private_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698