Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3359)

Unified Diff: chrome/browser/extensions/extension_service_unittest.cc

Issue 1534123002: [Extensions] Migrate ExtensionInstallPrompt::Delegate to be a callback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_service_unittest.cc
diff --git a/chrome/browser/extensions/extension_service_unittest.cc b/chrome/browser/extensions/extension_service_unittest.cc
index 084ca22814fe70d1471d610dadbbc41b610dd3ce..2de278bca3116b5d34a64f4a2f611bd7e4386522 100644
--- a/chrome/browser/extensions/extension_service_unittest.cc
+++ b/chrome/browser/extensions/extension_service_unittest.cc
@@ -6070,8 +6070,9 @@ TEST_F(ExtensionServiceTest, ExternalInstallClickToRemove) {
EXPECT_FALSE(registry()->enabled_extensions().GetByID(updates_from_webstore));
// Click the negative response.
- service_->external_install_manager()->error_for_testing()->InstallUIAbort(
- true);
+ service_->external_install_manager()
+ ->error_for_testing()
+ ->OnInstallPromptDone(ExtensionInstallPrompt::Result::USER_CANCELED);
// The Extension should be uninstalled.
EXPECT_FALSE(registry()->GetExtensionById(updates_from_webstore,
ExtensionRegistry::EVERYTHING));
@@ -6112,7 +6113,9 @@ TEST_F(ExtensionServiceTest, ExternalInstallClickToKeep) {
EXPECT_FALSE(registry()->enabled_extensions().GetByID(updates_from_webstore));
// Accept the extension.
- service_->external_install_manager()->error_for_testing()->InstallUIProceed();
+ service_->external_install_manager()
+ ->error_for_testing()
+ ->OnInstallPromptDone(ExtensionInstallPrompt::Result::ACCEPTED);
// It should be enabled again.
EXPECT_TRUE(registry()->enabled_extensions().GetByID(updates_from_webstore));

Powered by Google App Engine
This is Rietveld 408576698