Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Unified Diff: chrome/browser/extensions/api/dashboard_private/dashboard_private_api.h

Issue 1534123002: [Extensions] Migrate ExtensionInstallPrompt::Delegate to be a callback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/dashboard_private/dashboard_private_api.h
diff --git a/chrome/browser/extensions/api/dashboard_private/dashboard_private_api.h b/chrome/browser/extensions/api/dashboard_private/dashboard_private_api.h
index d181966ccfd84ad2f803055496817f35098f9931..f5da722741ebed64dfa11a13564bd1e0d3dcce8b 100644
--- a/chrome/browser/extensions/api/dashboard_private/dashboard_private_api.h
+++ b/chrome/browser/extensions/api/dashboard_private/dashboard_private_api.h
@@ -29,7 +29,6 @@ class Extension;
class DashboardPrivateShowPermissionPromptForDelegatedInstallFunction
: public UIThreadExtensionFunction,
- public ExtensionInstallPrompt::Delegate,
public WebstoreInstallHelper::Delegate {
public:
DECLARE_EXTENSION_FUNCTION(
@@ -55,9 +54,7 @@ class DashboardPrivateShowPermissionPromptForDelegatedInstallFunction
InstallHelperResultCode result,
const std::string& error_message) override;
- // ExtensionInstallPrompt::Delegate:
- void InstallUIProceed() override;
- void InstallUIAbort(bool user_initiated) override;
+ void OnInstallPromptDone(ExtensionInstallPrompt::Result result);
ExtensionFunction::ResponseValue BuildResponse(
api::dashboard_private::Result result,
@@ -74,6 +71,9 @@ class DashboardPrivateShowPermissionPromptForDelegatedInstallFunction
scoped_refptr<Extension> dummy_extension_;
scoped_ptr<ExtensionInstallPrompt> install_prompt_;
+
+ DISALLOW_COPY_AND_ASSIGN(
Avi (use Gerrit) 2015/12/29 03:10:45 #include "base/macros.h"
Devlin 2016/01/04 22:59:22 Done.
+ DashboardPrivateShowPermissionPromptForDelegatedInstallFunction);
};
class DashboardPrivateShowPermissionPromptForDelegatedBundleInstallFunction

Powered by Google App Engine
This is Rietveld 408576698