[Extensions] Migrate ExtensionInstallPrompt::Delegate to be a callback

chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/extensions/extension_install_dialog_view.h"
 
 #include <stddef.h>
 #include <algorithm>
 #include <string>
 #include <utility>
 #include <vector>
 
+#include "base/callback_helpers.h"
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
 #include "base/i18n/rtl.h"
 #include "base/macros.h"
 #include "base/metrics/histogram.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/extensions/api/experience_sampling_private/experience_sampling.h"
 #include "chrome/browser/extensions/bundle_installer.h"
@@ skipping 73 matching lines @@
 // like a entry in a bullet point list, one is added.
 base::string16 PrepareForDisplay(const base::string16& message,
                                  bool bullet_point) {
   return bullet_point ? l10n_util::GetStringFUTF16(
       IDS_EXTENSION_PERMISSION_LINE,
       message) : message;
 }
 
 void ShowExtensionInstallDialogImpl(
     ExtensionInstallPromptShowParams* show_params,
-    ExtensionInstallPrompt::Delegate* delegate,
+    const ExtensionInstallPrompt::DoneCallback& done_callback,
     scoped_ptr<ExtensionInstallPrompt::Prompt> prompt) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
   bool use_tab_modal_dialog = prompt->ShouldUseTabModalDialog();
   ExtensionInstallDialogView* dialog = new ExtensionInstallDialogView(
-      show_params->profile(), show_params->GetParentWebContents(), delegate,
-      std::move(prompt));
+      show_params->profile(), show_params->GetParentWebContents(),
+      done_callback, std::move(prompt));
   if (use_tab_modal_dialog) {
     content::WebContents* parent_web_contents =
         show_params->GetParentWebContents();
     if (parent_web_contents)
       constrained_window::ShowWebModalDialogViews(dialog, parent_web_contents);
   } else {
     constrained_window::CreateBrowserModalDialogViews(
         dialog, show_params->GetParentWindow())
         ->Show();
   }
@@ skipping 68 matching lines @@
   image_view->SetImage(image);
   image_view->SetImageSize(size);
 
   layout->AddView(image_view);
   layout->AddView(view);
 }
 
 ExtensionInstallDialogView::ExtensionInstallDialogView(
     Profile* profile,
     content::PageNavigator* navigator,
-    ExtensionInstallPrompt::Delegate* delegate,
+    const ExtensionInstallPrompt::DoneCallback& done_callback,
     scoped_ptr<ExtensionInstallPrompt::Prompt> prompt)
     : profile_(profile),
       navigator_(navigator),
-      delegate_(delegate),
+      done_callback_(done_callback),
       prompt_(std::move(prompt)),
       container_(NULL),
       scroll_view_(NULL),
       handled_result_(false) {
   InitView();
 }
 
 ExtensionInstallDialogView::~ExtensionInstallDialogView() {
-  if (!handled_result_)
-    delegate_->InstallUIAbort(true);
+  if (!handled_result_ && !done_callback_.is_null()) {
+    base::ResetAndReturn(&done_callback_)
+        .Run(ExtensionInstallPrompt::Result::USER_CANCELED);
+  }
 }
 
 void ExtensionInstallDialogView::InitView() {
   // Possible grid layouts:
   // With webstore data (inline install, external install, repair)
   //      w/ permissions           no permissions
   // +--------------+------+  +--------------+------+
   // | title        | icon |  | title        | icon |
   // +--------------|      |  +--------------|      |
   // | rating       |      |  | rating       |      |
@@ skipping 360 matching lines @@
 }
 
 bool ExtensionInstallDialogView::Cancel() {
   if (handled_result_)
     return true;
 
   handled_result_ = true;
   UpdateInstallResultHistogram(false);
   if (sampling_event_)
     sampling_event_->CreateUserDecisionEvent(ExperienceSamplingEvent::kDeny);
-  delegate_->InstallUIAbort(true);
+  base::ResetAndReturn(&done_callback_)
+      .Run(ExtensionInstallPrompt::Result::USER_CANCELED);
   return true;
 }
 
 bool ExtensionInstallDialogView::Accept() {
   DCHECK(!handled_result_);
 
   handled_result_ = true;
   UpdateInstallResultHistogram(true);
   if (sampling_event_)
     sampling_event_->CreateUserDecisionEvent(ExperienceSamplingEvent::kProceed);
-  delegate_->InstallUIProceed();
+  base::ResetAndReturn(&done_callback_)
+      .Run(ExtensionInstallPrompt::Result::ACCEPTED);
   return true;
 }
 
 ui::ModalType ExtensionInstallDialogView::GetModalType() const {
   return prompt_->ShouldUseTabModalDialog() ? ui::MODAL_TYPE_CHILD
                                             : ui::MODAL_TYPE_WINDOW;
 }
 
 void ExtensionInstallDialogView::LinkClicked(views::Link* source,
                                              int event_flags) {
@@ skipping 212 matching lines @@
       expanded ? gfx::VectorIconId::FIND_PREV : gfx::VectorIconId::FIND_NEXT,
       16, gfx::kChromeIconGrey);
   arrow_toggle_->SetImage(views::Button::STATE_NORMAL, &icon);
 }
 
 // static
 ExtensionInstallPrompt::ShowDialogCallback
 ExtensionInstallPrompt::GetDefaultShowDialogCallback() {
   return base::Bind(&ShowExtensionInstallDialogImpl);
 }