[Extensions] Migrate ExtensionInstallPrompt::Delegate to be a callback

chrome/browser/ui/extensions/extension_enable_flow.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/extensions/extension_enable_flow.h"
 
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_util.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profiles_state.h"
 #include "chrome/browser/ui/extensions/extension_enable_flow_delegate.h"
 #include "chrome/browser/ui/user_manager.h"
 #include "content/public/browser/notification_details.h"
 #include "content/public/browser/notification_source.h"
 #include "extensions/browser/extension_prefs.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/extension_system.h"
 
 using extensions::Extension;
 
 ExtensionEnableFlow::ExtensionEnableFlow(Profile* profile,
                                          const std::string& extension_id,
                                          ExtensionEnableFlowDelegate* delegate)
     : profile_(profile),
       extension_id_(extension_id),
       delegate_(delegate),
       parent_contents_(NULL),
       parent_window_(NULL),
-      extension_registry_observer_(this) {
-}
+      extension_registry_observer_(this),
+      weak_ptr_factory_(this) {}
 
 ExtensionEnableFlow::~ExtensionEnableFlow() {
 }
 
 void ExtensionEnableFlow::StartForWebContents(
     content::WebContents* parent_contents) {
   parent_contents_ = parent_contents;
   parent_window_ = NULL;
   Run();
 }
@@ skipping 68 matching lines @@
     service->EnableExtension(extension_id_);
 
     delegate_->ExtensionEnableFlowFinished();  // |delegate_| may delete us.
     return;
   }
 
   CreatePrompt();
   ExtensionInstallPrompt::PromptType type =
       ExtensionInstallPrompt::GetReEnablePromptTypeForExtension(profile_,
                                                                 extension);
-  prompt_->ShowDialog(this, extension, nullptr,
+  prompt_->ShowDialog(base::Bind(&ExtensionEnableFlow::InstallPromptDone,
+                                 weak_ptr_factory_.GetWeakPtr()),
+                      extension, nullptr,
                       make_scoped_ptr(new ExtensionInstallPrompt::Prompt(type)),
                       ExtensionInstallPrompt::GetDefaultShowDialogCallback());
 }
 
 void ExtensionEnableFlow::CreatePrompt() {
   if (!window_getter_.is_null())
     parent_window_ = window_getter_.Run();
   prompt_.reset(parent_contents_ ?
       new ExtensionInstallPrompt(parent_contents_) :
       new ExtensionInstallPrompt(profile_, parent_window_));
@@ skipping 32 matching lines @@
 void ExtensionEnableFlow::OnExtensionUninstalled(
     content::BrowserContext* browser_context,
     const Extension* extension,
     extensions::UninstallReason reason) {
   if (extension->id() == extension_id_) {
     StopObserving();
     delegate_->ExtensionEnableFlowAborted(false);
   }
 }
 
-void ExtensionEnableFlow::InstallUIProceed() {
-  ExtensionService* service =
-      extensions::ExtensionSystem::Get(profile_)->extension_service();
+void ExtensionEnableFlow::InstallPromptDone(
+    ExtensionInstallPrompt::Result result) {
+  if (result == ExtensionInstallPrompt::Result::ACCEPTED) {
+    ExtensionService* service =
+        extensions::ExtensionSystem::Get(profile_)->extension_service();
 
-  // The extension can be uninstalled in another window while the UI was
-  // showing. Treat it as a cancellation and notify |delegate_|.
-  const Extension* extension = service->GetExtensionById(extension_id_, true);
-  if (!extension) {
-    delegate_->ExtensionEnableFlowAborted(true);
-    return;
+    // The extension can be uninstalled in another window while the UI was
+    // showing. Treat it as a cancellation and notify |delegate_|.
+    const Extension* extension = service->GetExtensionById(extension_id_, true);
+    if (!extension) {
+      delegate_->ExtensionEnableFlowAborted(true);
+      return;
+    }
+
+    service->GrantPermissionsAndEnableExtension(extension);
+    delegate_->ExtensionEnableFlowFinished();  // |delegate_| may delete us.
+  } else {
+    delegate_->ExtensionEnableFlowAborted(
+        result == ExtensionInstallPrompt::Result::USER_CANCELED);
+    // |delegate_| may delete us.
   }
-
-  service->GrantPermissionsAndEnableExtension(extension);
-  delegate_->ExtensionEnableFlowFinished();  // |delegate_| may delete us.
 }
-
-void ExtensionEnableFlow::InstallUIAbort(bool user_initiated) {
-  delegate_->ExtensionEnableFlowAborted(user_initiated);
-  // |delegate_| may delete us.
-}