[Extensions] Migrate ExtensionInstallPrompt::Delegate to be a callback

chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Cocoa/Cocoa.h>
 
 #import "base/mac/scoped_nsobject.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #import "chrome/browser/extensions/extension_install_prompt.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/cocoa/cocoa_profile_test.h"
 #import "chrome/browser/ui/cocoa/extensions/extension_install_prompt_test_utils.h"
 #import "chrome/browser/ui/cocoa/extensions/extension_install_view_controller.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/permissions/permission_message_provider.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #import "testing/gtest_mac.h"
 
 using extensions::Extension;
 using extensions::PermissionIDSet;
 using extensions::PermissionMessage;
 using extensions::PermissionMessages;
 
+namespace {
+
+class MockExtensionInstallViewDelegate : public ExtensionInstallViewDelegate {
+ public:
+  enum class Action {
+    UNDEFINED,
+    OKAY,
+    CANCEL,
+    LINK,
+  };
+
+  MockExtensionInstallViewDelegate() : action_(Action::UNDEFINED) {}
+  ~MockExtensionInstallViewDelegate() override {}
+
+  void OnOkButtonClicked() override { SetAction(Action::OKAY); }
+  void OnCancelButtonClicked() override { SetAction(Action::CANCEL); }
+  void OnStoreLinkClicked() override { SetAction(Action::LINK); }
+
+  Action action() const { return action_; }
+
+ private:
+  void SetAction(Action action) {
+    if (action_ != Action::UNDEFINED)
+      ADD_FAILURE() << "SetAction() called twice!";
+    action_ = action;
+  }
+
+  Action action_;
+
+  DISALLOW_COPY_AND_ASSIGN(MockExtensionInstallViewDelegate);
+};
+
 // Base class for our tests.
 class ExtensionInstallViewControllerTest : public CocoaProfileTest {
  public:
   ExtensionInstallViewControllerTest() {
     extension_ = chrome::LoadInstallPromptExtension();
   }
 
  protected:
   scoped_refptr<extensions::Extension> extension_;
 };
 
+}  // namespace
+
 // Test that we can load the two kinds of prompts correctly, that the outlets
 // are hooked up, and that the dialog calls cancel when cancel is pressed.
 TEST_F(ExtensionInstallViewControllerTest, BasicsNormalCancel) {
-  chrome::MockExtensionInstallPromptDelegate delegate;
+  MockExtensionInstallViewDelegate delegate;
 
   scoped_ptr<ExtensionInstallPrompt::Prompt> prompt(
       chrome::BuildExtensionInstallPrompt(extension_.get()));
   ExtensionInstallPrompt::PermissionsType type =
       ExtensionInstallPrompt::PermissionsType::REGULAR_PERMISSIONS;
 
   PermissionMessages permissions;
   permissions.push_back(PermissionMessage(base::UTF8ToUTF16("warning 1"),
                                           PermissionIDSet()));
   prompt->SetPermissions(permissions, type);
@@ skipping 29 matching lines @@
                                              byItem:[outlineView itemAtRow:1]]);
 
   EXPECT_TRUE([controller cancelButton]);
   EXPECT_NE(0u, [[[controller cancelButton] stringValue] length]);
   EXPECT_NE('^', [[[controller cancelButton] stringValue] characterAtIndex:0]);
 
   EXPECT_TRUE([controller okButton]);
   EXPECT_NE(0u, [[[controller okButton] stringValue] length]);
   EXPECT_NE('^', [[[controller okButton] stringValue] characterAtIndex:0]);
 
-  // Test that cancel calls our delegate.
+  // Test that cancel calls our callback.
   [controller cancel:nil];
-  EXPECT_EQ(1, delegate.abort_count());
-  EXPECT_EQ(0, delegate.proceed_count());
+  EXPECT_EQ(MockExtensionInstallViewDelegate::Action::CANCEL,
+            delegate.action());
 }
 
 TEST_F(ExtensionInstallViewControllerTest, BasicsNormalOK) {
-  chrome::MockExtensionInstallPromptDelegate delegate;
+  MockExtensionInstallViewDelegate delegate;
 
   scoped_ptr<ExtensionInstallPrompt::Prompt> prompt(
       chrome::BuildExtensionInstallPrompt(extension_.get()));
   ExtensionInstallPrompt::PermissionsType type =
       ExtensionInstallPrompt::PermissionsType::REGULAR_PERMISSIONS;
 
   PermissionMessages permissions;
   permissions.push_back(PermissionMessage(base::UTF8ToUTF16("warning 1"),
                                           PermissionIDSet()));
   prompt->SetPermissions(permissions, type);
 
   base::scoped_nsobject<ExtensionInstallViewController> controller(
       [[ExtensionInstallViewController alloc] initWithProfile:profile()
                                                     navigator:browser()
                                                      delegate:&delegate
                                                        prompt:prompt.Pass()]);
 
   [controller view];  // Force nib load.
   [controller ok:nil];
 
-  EXPECT_EQ(0, delegate.abort_count());
-  EXPECT_EQ(1, delegate.proceed_count());
+  EXPECT_EQ(MockExtensionInstallViewDelegate::Action::OKAY,
+            delegate.action());
 }
 
 // Test that controls get repositioned when there are two warnings vs one
 // warning.
 TEST_F(ExtensionInstallViewControllerTest, MultipleWarnings) {
-  chrome::MockExtensionInstallPromptDelegate delegate1;
-  chrome::MockExtensionInstallPromptDelegate delegate2;
+  MockExtensionInstallViewDelegate delegate1;
+  MockExtensionInstallViewDelegate delegate2;
 
   scoped_ptr<ExtensionInstallPrompt::Prompt> one_warning_prompt(
       chrome::BuildExtensionInstallPrompt(extension_.get()));
   ExtensionInstallPrompt::PermissionsType type =
       ExtensionInstallPrompt::PermissionsType::REGULAR_PERMISSIONS;
 
   PermissionMessages permissions;
   permissions.push_back(PermissionMessage(base::UTF8ToUTF16("warning 1"),
                                           PermissionIDSet()));
   one_warning_prompt->SetPermissions(permissions, type);
@@ skipping 28 matching lines @@
   ASSERT_LT([[controller1 view] frame].size.height,
             [[controller2 view] frame].size.height);
 
   ASSERT_LT([[controller1 view] frame].size.height,
             [[controller2 view] frame].size.height);
 }
 
 // Test that we can load the skinny prompt correctly, and that the outlets are
 // are hooked up.
 TEST_F(ExtensionInstallViewControllerTest, BasicsSkinny) {
-  chrome::MockExtensionInstallPromptDelegate delegate;
+  MockExtensionInstallViewDelegate delegate;
 
   // No warnings should trigger skinny prompt.
   scoped_ptr<ExtensionInstallPrompt::Prompt> no_warnings_prompt(
       chrome::BuildExtensionInstallPrompt(extension_.get()));
 
   base::scoped_nsobject<ExtensionInstallViewController> controller(
       [[ExtensionInstallViewController alloc]
           initWithProfile:profile()
                 navigator:browser()
                  delegate:&delegate
@@ skipping 21 matching lines @@
   EXPECT_NE(0u, [[[controller okButton] stringValue] length]);
   EXPECT_NE('^', [[[controller okButton] stringValue] characterAtIndex:0]);
 
   EXPECT_FALSE([controller outlineView]);
 }
 
 
 // Test that we can load the inline prompt correctly, and that the outlets are
 // are hooked up.
 TEST_F(ExtensionInstallViewControllerTest, BasicsInline) {
-  chrome::MockExtensionInstallPromptDelegate delegate;
+  MockExtensionInstallViewDelegate delegate;
 
   // No warnings should trigger skinny prompt.
   scoped_ptr<ExtensionInstallPrompt::Prompt> inline_prompt(
       new ExtensionInstallPrompt::Prompt(
           ExtensionInstallPrompt::INLINE_INSTALL_PROMPT));
   inline_prompt->SetWebstoreData("1,000", true, 3.5, 200);
   inline_prompt->set_extension(extension_.get());
   inline_prompt->set_icon(chrome::LoadInstallPromptIcon());
 
   base::scoped_nsobject<ExtensionInstallViewController> controller(
@@ skipping 39 matching lines @@
 
   // Though we have no permissions warnings, these should still be hooked up,
   // just invisible.
   EXPECT_TRUE([controller outlineView]);
   EXPECT_TRUE([[[controller outlineView] enclosingScrollView] isHidden]);
   EXPECT_TRUE([controller warningsSeparator]);
   EXPECT_TRUE([[controller warningsSeparator] isHidden]);
 }
 
 TEST_F(ExtensionInstallViewControllerTest, PostInstallPermissionsPrompt) {
-  chrome::MockExtensionInstallPromptDelegate delegate;
+  MockExtensionInstallViewDelegate delegate;
 
   scoped_ptr<ExtensionInstallPrompt::Prompt> prompt(
       chrome::BuildExtensionPostInstallPermissionsPrompt(extension_.get()));
   ExtensionInstallPrompt::PermissionsType type =
       ExtensionInstallPrompt::PermissionsType::REGULAR_PERMISSIONS;
 
   PermissionMessages permissions;
   permissions.push_back(PermissionMessage(base::UTF8ToUTF16("warning 1"),
                                           PermissionIDSet()));
   prompt->SetPermissions(permissions, type);
 
   base::scoped_nsobject<ExtensionInstallViewController> controller(
       [[ExtensionInstallViewController alloc] initWithProfile:profile()
                                                     navigator:browser()
                                                      delegate:&delegate
                                                        prompt:prompt.Pass()]);
 
   [controller view];  // Force nib load.
 
   EXPECT_TRUE([controller cancelButton]);
   EXPECT_FALSE([controller okButton]);
 
   [controller cancel:nil];
-  EXPECT_EQ(1, delegate.abort_count());
+  EXPECT_EQ(MockExtensionInstallViewDelegate::Action::CANCEL,
+            delegate.action());
 }
 
 // Test that permission details show up.
 TEST_F(ExtensionInstallViewControllerTest, PermissionsDetails) {
-  chrome::MockExtensionInstallPromptDelegate delegate;
+  MockExtensionInstallViewDelegate delegate;
 
   scoped_ptr<ExtensionInstallPrompt::Prompt> prompt(
       chrome::BuildExtensionInstallPrompt(extension_.get()));
   ExtensionInstallPrompt::PermissionsType type =
       ExtensionInstallPrompt::PermissionsType::REGULAR_PERMISSIONS;
 
   PermissionMessages permissions;
   permissions.push_back(PermissionMessage(
       base::UTF8ToUTF16("warning 1"),
       PermissionIDSet(),
@@ skipping 12 matching lines @@
   [controller view];  // Force nib load.
 
   NSOutlineView* outlineView = [controller outlineView];
   EXPECT_TRUE(outlineView);
   EXPECT_EQ(4, [outlineView numberOfRows]);
   EXPECT_NSEQ(base::SysUTF16ToNSString(permissionString),
               [[outlineView dataSource] outlineView:outlineView
                           objectValueForTableColumn:nil
                                              byItem:[outlineView itemAtRow:2]]);
 }