[Extensions] Migrate ExtensionInstallPrompt::Delegate to be a callback

chrome/browser/extensions/webstore_standalone_installer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/webstore_standalone_installer.h"
 
 #include <utility>
 
 #include "base/values.h"
 #include "base/version.h"
@@ skipping 117 matching lines @@
   scoped_active_install_.reset();
   if (!callback_.is_null())
     callback_.Run(result == webstore_install::SUCCESS, error, result);
   Release();  // Matches the AddRef in BeginInstall.
 }
 
 void WebstoreStandaloneInstaller::ProceedWithInstallPrompt() {
   install_prompt_ = CreateInstallPrompt();
   if (install_prompt_.get()) {
     ShowInstallUI();
-    // Control flow finishes up in InstallUIProceed or InstallUIAbort.
+    // Control flow finishes up in OnInstallPromptDone().
   } else {
-    InstallUIProceed();
+    OnInstallPromptDone(ExtensionInstallPrompt::Result::ACCEPTED);
   }
 }
 
 scoped_refptr<const Extension>
 WebstoreStandaloneInstaller::GetLocalizedExtensionForDisplay() {
   if (!localized_extension_for_display_.get()) {
     DCHECK(manifest_.get());
     if (!manifest_.get())
       return NULL;
 
@@ skipping 31 matching lines @@
           profile_,
           id_,
           scoped_ptr<base::DictionaryValue>(manifest_.get()->DeepCopy()),
           true));
   approval->skip_post_install_ui = !ShouldShowPostInstallUI();
   approval->use_app_installed_bubble = ShouldShowAppInstalledBubble();
   approval->installing_icon = gfx::ImageSkia::CreateFrom1xBitmap(icon_);
   return approval;
 }
 
-void WebstoreStandaloneInstaller::InstallUIProceed() {
-  if (!CheckRequestorAlive()) {
+void WebstoreStandaloneInstaller::OnInstallPromptDone(
+    ExtensionInstallPrompt::Result result) {
+  if (result == ExtensionInstallPrompt::Result::USER_CANCELED) {
+    CompleteInstall(webstore_install::USER_CANCELLED, kUserCancelledError);
+    return;
+  }
+
+  if (result == ExtensionInstallPrompt::Result::ABORTED ||
+      !CheckRequestorAlive()) {
     CompleteInstall(webstore_install::ABORTED, std::string());
     return;
   }
 
+  DCHECK(result == ExtensionInstallPrompt::Result::ACCEPTED);
+
   scoped_ptr<WebstoreInstaller::Approval> approval = CreateApproval();
 
   ExtensionService* extension_service =
       ExtensionSystem::Get(profile_)->extension_service();
   const Extension* installed_extension =
       extension_service->GetExtensionById(id_, true /* include disabled */);
   if (installed_extension) {
     std::string install_message;
     webstore_install::Result install_result = webstore_install::SUCCESS;
     bool done = true;
@@ skipping 13 matching lines @@
       return;
     }
   }
 
   scoped_refptr<WebstoreInstaller> installer =
       new WebstoreInstaller(profile_, this, GetWebContents(), id_,
                             std::move(approval), install_source_);
   installer->Start();
 }
 
-void WebstoreStandaloneInstaller::InstallUIAbort(bool user_initiated) {
-  CompleteInstall(webstore_install::USER_CANCELLED, kUserCancelledError);
-}
-
 void WebstoreStandaloneInstaller::OnWebstoreRequestFailure() {
   OnWebStoreDataFetcherDone();
   CompleteInstall(webstore_install::WEBSTORE_REQUEST_ERROR,
                   kWebstoreRequestError);
 }
 
 void WebstoreStandaloneInstaller::OnWebstoreResponseParseSuccess(
     scoped_ptr<base::DictionaryValue> webstore_data) {
   OnWebStoreDataFetcherDone();
 
@@ skipping 152 matching lines @@
 void WebstoreStandaloneInstaller::ShowInstallUI() {
   scoped_refptr<const Extension> localized_extension =
       GetLocalizedExtensionForDisplay();
   if (!localized_extension.get()) {
     CompleteInstall(webstore_install::INVALID_MANIFEST, kInvalidManifestError);
     return;
   }
 
   install_ui_ = CreateInstallUI();
   install_ui_->ShowDialog(
-      this, localized_extension.get(), &icon_, std::move(install_prompt_),
+      base::Bind(&WebstoreStandaloneInstaller::OnInstallPromptDone, this),
+      localized_extension.get(), &icon_, std::move(install_prompt_),
       ExtensionInstallPrompt::GetDefaultShowDialogCallback());
 }
 
 void WebstoreStandaloneInstaller::OnWebStoreDataFetcherDone() {
   // An instance of this class is passed in as a delegate for the
   // WebstoreInstallHelper, ExtensionInstallPrompt and WebstoreInstaller, and
   // therefore needs to remain alive until they are done. Clear the webstore
   // data fetcher to avoid calling Release in AbortInstall while any of these
   // operations are in progress.
   webstore_data_fetcher_.reset();
 }
 
 }  // namespace extensions