[Extensions] Migrate ExtensionInstallPrompt::Delegate to be a callback

chrome/browser/extensions/extension_install_prompt_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/macros.h"
@@ skipping 22 matching lines @@
 #include "ui/gfx/skia_util.h"
 
 namespace extensions {
 
 namespace {
 
 void VerifyPromptIconCallback(
     const base::Closure& quit_closure,
     const SkBitmap& expected_bitmap,
     ExtensionInstallPromptShowParams* params,
-    ExtensionInstallPrompt::Delegate* delegate,
+    const ExtensionInstallPrompt::DoneCallback& done_callback,
     scoped_ptr<ExtensionInstallPrompt::Prompt> prompt) {
   EXPECT_TRUE(gfx::BitmapsAreEqual(prompt->icon().AsBitmap(), expected_bitmap));
   quit_closure.Run();
 }
 
 void VerifyPromptPermissionsCallback(
     const base::Closure& quit_closure,
     size_t regular_permissions_count,
     size_t withheld_permissions_count,
     ExtensionInstallPromptShowParams* params,
-    ExtensionInstallPrompt::Delegate* delegate,
+    const ExtensionInstallPrompt::DoneCallback& done_callback,
     scoped_ptr<ExtensionInstallPrompt::Prompt> install_prompt) {
   ASSERT_TRUE(install_prompt.get());
   EXPECT_EQ(regular_permissions_count,
             install_prompt->GetPermissionCount(
                 ExtensionInstallPrompt::REGULAR_PERMISSIONS));
   EXPECT_EQ(withheld_permissions_count,
             install_prompt->GetPermissionCount(
                 ExtensionInstallPrompt::WITHHELD_PERMISSIONS));
   quit_closure.Run();
 }
@@ skipping 41 matching lines @@
                                      .Set("name", "foo")
                                      .Set("version", "1.0")
                                      .Set("manifest_version", 2)
                                      .Set("description", "Random Ext")))
           .Build();
 
   content::TestWebContentsFactory factory;
   ExtensionInstallPrompt prompt(factory.CreateWebContents(profile()));
   base::RunLoop run_loop;
   prompt.ShowDialog(
-      nullptr,  // no delegate
-      extension.get(), nullptr,
+      ExtensionInstallPrompt::DoneCallback(), extension.get(), nullptr,
       make_scoped_ptr(new ExtensionInstallPrompt::Prompt(
           ExtensionInstallPrompt::PERMISSIONS_PROMPT)),
       std::move(permission_set),
       base::Bind(&VerifyPromptPermissionsCallback, run_loop.QuitClosure(),
                  1u,    // |regular_permissions_count|.
                  0u));  // |withheld_permissions_count|.
   run_loop.Run();
 }
 
 TEST_F(ExtensionInstallPromptUnitTest, PromptShowsWithheldPermissions) {
@@ skipping 16 matching lines @@
                                                .Append("tabs")))))
           .Build();
 
   content::TestWebContentsFactory factory;
   ExtensionInstallPrompt prompt(factory.CreateWebContents(profile()));
   base::RunLoop run_loop;
 
   // We expect <all_hosts> to be withheld, but http://www.google.com/ and tabs
   // permissions should be granted as regular permissions.
   prompt.ShowDialog(
-      nullptr, extension.get(), nullptr,
+      ExtensionInstallPrompt::DoneCallback(), extension.get(), nullptr,
       base::Bind(&VerifyPromptPermissionsCallback, run_loop.QuitClosure(),
                  2u,    // |regular_permissions_count|.
                  1u));  // |withheld_permissions_count|.
   run_loop.Run();
 }
 
 TEST_F(ExtensionInstallPromptUnitTest,
        DelegatedPromptShowsOptionalPermissions) {
   scoped_refptr<const Extension> extension =
       ExtensionBuilder()
@@ skipping 11 matching lines @@
 
   content::TestWebContentsFactory factory;
   ExtensionInstallPrompt prompt(factory.CreateWebContents(profile()));
   base::RunLoop run_loop;
 
   scoped_ptr<ExtensionInstallPrompt::Prompt> sub_prompt(
       new ExtensionInstallPrompt::Prompt(
           ExtensionInstallPrompt::DELEGATED_PERMISSIONS_PROMPT));
   sub_prompt->set_delegated_username("Username");
   prompt.ShowDialog(
-      nullptr,  // no delegate
-      extension.get(), nullptr, std::move(sub_prompt),
+      ExtensionInstallPrompt::DoneCallback(), extension.get(), nullptr,
+      std::move(sub_prompt),
       base::Bind(&VerifyPromptPermissionsCallback, run_loop.QuitClosure(),
                  2u,    // |regular_permissions_count|.
                  0u));  // |withheld_permissions_count|.
   run_loop.Run();
 }
 
 using ExtensionInstallPromptTestWithService = ExtensionServiceTestWithInstall;
 
 TEST_F(ExtensionInstallPromptTestWithService, ExtensionInstallPromptIconsTest) {
   InitializeEmptyExtensionService();
@@ skipping 16 matching lines @@
           extension, image_rep,
           base::Bind(&SetImage, &image, image_loop.QuitClosure()));
   image_loop.Run();
   ASSERT_FALSE(image.IsEmpty());
   content::TestWebContentsFactory factory;
   content::WebContents* web_contents =
       factory.CreateWebContents(browser_context());
   {
     ExtensionInstallPrompt prompt(web_contents);
     base::RunLoop run_loop;
-    prompt.ShowDialog(nullptr,  // No delegate.
+    prompt.ShowDialog(ExtensionInstallPrompt::DoneCallback(),
                       extension,
                       nullptr,  // Force an icon fetch.
                       base::Bind(&VerifyPromptIconCallback,
                                  run_loop.QuitClosure(), image.AsBitmap()));
     run_loop.Run();
   }
 
   {
     ExtensionInstallPrompt prompt(web_contents);
     base::RunLoop run_loop;
     gfx::ImageSkia app_icon = util::GetDefaultAppIcon();
-    prompt.ShowDialog(nullptr,  // No delegate.
+    prompt.ShowDialog(ExtensionInstallPrompt::DoneCallback(),
                       extension,
                       app_icon.bitmap(),  // Use a different icon.
                       base::Bind(&VerifyPromptIconCallback,
                                  run_loop.QuitClosure(), *app_icon.bitmap()));
     run_loop.Run();
   }
 }
 
 }  // namespace extensions