[Extensions] Migrate ExtensionInstallPrompt::Delegate to be a callback

chrome/browser/ui/views/extensions/extension_install_dialog_view.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_EXTENSIONS_EXTENSION_INSTALL_DIALOG_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_EXTENSIONS_EXTENSION_INSTALL_DIALOG_VIEW_H_
 
 #include "base/macros.h"
 #include "chrome/browser/extensions/extension_install_prompt.h"
 #include "ui/gfx/animation/animation_delegate.h"
@@ skipping 21 matching lines @@
 namespace views {
 class GridLayout;
 class ImageButton;
 class Link;
 }
 
 // Implements the extension installation dialog for TOOLKIT_VIEWS.
 class ExtensionInstallDialogView : public views::DialogDelegateView,
                                    public views::LinkListener {
  public:
-  ExtensionInstallDialogView(Profile* profile,
-                             content::PageNavigator* navigator,
-                             ExtensionInstallPrompt::Delegate* delegate,
-                             scoped_ptr<ExtensionInstallPrompt::Prompt> prompt);
+  ExtensionInstallDialogView(
+      Profile* profile,
+      content::PageNavigator* navigator,
+      const ExtensionInstallPrompt::DoneCallback& done_callback,
+      scoped_ptr<ExtensionInstallPrompt::Prompt> prompt);
   ~ExtensionInstallDialogView() override;
 
   // Returns the interior ScrollView of the dialog. This allows us to inspect
   // the contents of the DialogView.
   const views::ScrollView* scroll_view() const { return scroll_view_; }
 
  private:
   // views::DialogDelegateView:
   int GetDialogButtons() const override;
   base::string16 GetDialogButtonLabel(ui::DialogButton button) const override;
@@ skipping 28 matching lines @@
 
   bool is_external_install() const {
     return prompt_->type() == ExtensionInstallPrompt::EXTERNAL_INSTALL_PROMPT;
   }
 
   // Updates the histogram that holds installation accepted/aborted data.
   void UpdateInstallResultHistogram(bool accepted) const;
 
   Profile* profile_;
   content::PageNavigator* navigator_;
-  ExtensionInstallPrompt::Delegate* delegate_;
+  ExtensionInstallPrompt::DoneCallback done_callback_;
   scoped_ptr<ExtensionInstallPrompt::Prompt> prompt_;
 
   // The container view that contains all children (heading, icon, webstore
   // data, and the scroll view with permissions etc.), excluding the buttons,
   // which are added automatically by the dialog system.
   View* container_;
 
   // The scroll view containing all the details for the dialog (including all
   // collapsible/expandable sections).
   views::ScrollView* scroll_view_;
 
   // The preferred size of the dialog.
   gfx::Size dialog_size_;
 
   // ExperienceSampling: Track this UI event.
   scoped_ptr<extensions::ExperienceSamplingEvent> sampling_event_;
 
-  // Set to true once the user's selection has been received and the
-  // |delegate_| has been notified.
+  // Set to true once the user's selection has been received and the callback
+  // has been ran.

[Avi (use Gerrit), 2015/12/29 03:10:45]

"... has been run"?

[Devlin, 2016/01/04 22:59:23]

Dang English.  Done.

   bool handled_result_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionInstallDialogView);
 };
 
 // A simple view that prepends a view with a bullet with the help of a grid
 // layout.
 class BulletedView : public views::View {
  public:
   explicit BulletedView(views::View* view);
@@ skipping 80 matching lines @@
   // on whether the details section is expanded).
   views::ImageButton* arrow_toggle_;
 
   // Whether the details section is expanded.
   bool expanded_;
 
   DISALLOW_COPY_AND_ASSIGN(ExpandableContainerView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_EXTENSIONS_EXTENSION_INSTALL_DIALOG_VIEW_H_