[Extensions] Migrate ExtensionInstallPrompt::Delegate to be a callback

chrome/browser/ui/cocoa/extensions/extension_install_view_controller.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_COCOA_EXTENSIONS_EXTENSION_INSTALL_VIEW_CONTROLLER_H_
 #define CHROME_BROWSER_UI_COCOA_EXTENSIONS_EXTENSION_INSTALL_VIEW_CONTROLLER_H_
 
 #include <vector>
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/mac/scoped_nsobject.h"
 #include "base/memory/ref_counted.h"
 #include "base/strings/string16.h"
 #include "chrome/browser/extensions/extension_install_prompt.h"
 #include "ui/gfx/image/image_skia.h"
 
 class Profile;
 
 namespace content {
 class PageNavigator;
 }
 
+class ExtensionInstallViewDelegate {

[Devlin, 2015/12/29 00:12:52]

It was incredibly confusing to me that two different objects would conditionally
call the ExtensionInstallPrompt::Delegate methods, and this makes it much
clearer where division of control lies.  Let me know if you think differently.

+ public:
+  virtual void OnOkButtonClicked() = 0;
+  virtual void OnCancelButtonClicked() = 0;
+  virtual void OnStoreLinkClicked() = 0;
+
+ protected:
+  virtual ~ExtensionInstallViewDelegate() {}
+};
+
 // Displays the extension or bundle install prompt, and notifies the
-// ExtensionInstallPrompt::Delegate of success or failure
+// Delegate of success or failure.
 @interface ExtensionInstallViewController : NSViewController
                                            <NSOutlineViewDataSource,
                                             NSOutlineViewDelegate> {
   IBOutlet NSImageView* iconView_;
   IBOutlet NSTextField* titleField_;
   IBOutlet NSTextField* itemsField_;
   IBOutlet NSButton* cancelButton_;
   IBOutlet NSButton* okButton_;
 
   // Present only when the dialog has permission warnings issues to display.
   IBOutlet NSOutlineView* outlineView_;
 
   // Present only in the install dialogs with webstore data (inline and
   // external).
   IBOutlet NSBox* warningsSeparator_; // Only when there are permissions.
   IBOutlet NSView* ratingStars_;
   IBOutlet NSTextField* ratingCountField_;
   IBOutlet NSTextField* userCountField_;
   IBOutlet NSButton* storeLinkButton_;
 
   Profile* profile_; // weak
   content::PageNavigator* navigator_;  // weak
-  ExtensionInstallPrompt::Delegate* delegate_;  // weak
+  ExtensionInstallViewDelegate* delegate_;  // weak
   scoped_ptr<ExtensionInstallPrompt::Prompt> prompt_;
 
   base::scoped_nsobject<NSArray> warnings_;
   BOOL isComputingRowHeight_;
 }
 
 // For unit test use only.
 @property(nonatomic, readonly) NSImageView* iconView;
 @property(nonatomic, readonly) NSTextField* titleField;
 @property(nonatomic, readonly) NSTextField* itemsField;
 @property(nonatomic, readonly) NSButton* cancelButton;
 @property(nonatomic, readonly) NSButton* okButton;
 @property(nonatomic, readonly) NSOutlineView* outlineView;
 @property(nonatomic, readonly) NSBox* warningsSeparator;
 @property(nonatomic, readonly) NSView* ratingStars;
 @property(nonatomic, readonly) NSTextField* ratingCountField;
 @property(nonatomic, readonly) NSTextField* userCountField;
 @property(nonatomic, readonly) NSButton* storeLinkButton;
 
 - (id)initWithProfile:(Profile*)profile
             navigator:(content::PageNavigator*)navigator
-             delegate:(ExtensionInstallPrompt::Delegate*)delegate
+             delegate:(ExtensionInstallViewDelegate*)delegate
                prompt:(scoped_ptr<ExtensionInstallPrompt::Prompt>)prompt;
 - (IBAction)storeLinkClicked:(id)sender; // Callback for "View details" link.
 - (IBAction)cancel:(id)sender;
 - (IBAction)ok:(id)sender;
 
 @end
 
 #endif  // CHROME_BROWSER_UI_COCOA_EXTENSIONS_EXTENSION_INSTALL_VIEW_CONTROLLER_H_