[Extensions] Migrate ExtensionInstallPrompt::Delegate to be a callback

chrome/browser/extensions/navigation_observer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/navigation_observer.h"
 
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "content/public/browser/navigation_controller.h"
 #include "content/public/browser/navigation_entry.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/notification_types.h"
 #include "extensions/browser/extension_prefs.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/extension_system.h"
 
 using content::NavigationController;
 using content::NavigationEntry;
 
 namespace extensions {
 
-NavigationObserver::NavigationObserver(Profile* profile) : profile_(profile) {
+NavigationObserver::NavigationObserver(Profile* profile)
+    : profile_(profile), weak_factory_(this) {
   RegisterForNotifications();
 }
 
 NavigationObserver::~NavigationObserver() {}
 
 void NavigationObserver::Observe(int type,
                                  const content::NotificationSource& source,
                                  const content::NotificationDetails& details) {
   if (type != content::NOTIFICATION_NAV_ENTRY_COMMITTED) {
     NOTREACHED();
@@ skipping 32 matching lines @@
     return;
 
   // Try not to repeatedly prompt the user about the same extension.
   if (prompted_extensions_.find(extension->id()) != prompted_extensions_.end())
     return;
   prompted_extensions_.insert(extension->id());
 
   ExtensionPrefs* extension_prefs = ExtensionPrefs::Get(profile_);
   if (extension_prefs->DidExtensionEscalatePermissions(extension->id())) {
     // Keep track of the extension id and nav controller we're prompting for.
-    // These must be reset in InstallUIProceed and InstallUIAbort.
+    // These must be reset in OnInstallPromptDone.
     in_progress_prompt_extension_id_ = extension->id();
     in_progress_prompt_navigation_controller_ = nav_controller;
 
     extension_install_prompt_.reset(
         new ExtensionInstallPrompt(nav_controller->GetWebContents()));
     ExtensionInstallPrompt::PromptType type =
         ExtensionInstallPrompt::GetReEnablePromptTypeForExtension(profile_,
                                                                   extension);
     extension_install_prompt_->ShowDialog(
-        this, extension, nullptr,
+        base::Bind(&NavigationObserver::OnInstallPromptDone,
+                   weak_factory_.GetWeakPtr()),
+        extension, nullptr,
         make_scoped_ptr(new ExtensionInstallPrompt::Prompt(type)),
         ExtensionInstallPrompt::GetDefaultShowDialogCallback());
   }
 }
 
-void NavigationObserver::InstallUIProceed() {
-  ExtensionService* extension_service =
-      extensions::ExtensionSystem::Get(profile_)->extension_service();
-  const Extension* extension = extension_service->GetExtensionById(
-      in_progress_prompt_extension_id_, true);
-  NavigationController* nav_controller =
-      in_progress_prompt_navigation_controller_;
-  CHECK(extension);
-  CHECK(nav_controller);
-
-  in_progress_prompt_extension_id_ = "";
-  in_progress_prompt_navigation_controller_ = NULL;
-  extension_install_prompt_.reset();
-
-  // Grant permissions, re-enable the extension, and then reload the tab.
-  extension_service->GrantPermissionsAndEnableExtension(extension);
-  nav_controller->Reload(true);
-}
-
-void NavigationObserver::InstallUIAbort(bool user_initiated) {
+void NavigationObserver::OnInstallPromptDone(
+    ExtensionInstallPrompt::Result result) {
   ExtensionService* extension_service =
       extensions::ExtensionSystem::Get(profile_)->extension_service();
   const Extension* extension = extension_service->GetExtensionById(
       in_progress_prompt_extension_id_, true);
 
-  in_progress_prompt_extension_id_ = "";
-  in_progress_prompt_navigation_controller_ = NULL;
+  if (result == ExtensionInstallPrompt::Result::ACCEPTED) {
+    NavigationController* nav_controller =
+        in_progress_prompt_navigation_controller_;
+    CHECK(extension);
+    CHECK(nav_controller);
+
+    // Grant permissions, re-enable the extension, and then reload the tab.
+    extension_service->GrantPermissionsAndEnableExtension(extension);
+    nav_controller->Reload(true);
+  } else {
+    std::string histogram_name =
+        result == ExtensionInstallPrompt::Result::USER_CANCELED
+            ? "ReEnableCancel"
+            : "ReEnableAbort";
+    ExtensionService::RecordPermissionMessagesHistogram(extension,
+                                                        histogram_name.c_str());
+  }
+
+  in_progress_prompt_extension_id_ = std::string();
+  in_progress_prompt_navigation_controller_ = nullptr;
   extension_install_prompt_.reset();
-
-  std::string histogram_name = user_initiated ? "ReEnableCancel"
-                                              : "ReEnableAbort";
-  ExtensionService::RecordPermissionMessagesHistogram(
-      extension, histogram_name.c_str());
 }
 
 }  // namespace extensions