[Extensions] Migrate ExtensionInstallPrompt::Delegate to be a callback

chrome/browser/extensions/extension_install_prompt.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_INSTALL_PROMPT_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_INSTALL_PROMPT_H_
 
 #include <stddef.h>
 
 #include <string>
@@ skipping 241 matching lines @@
 
     std::vector<base::FilePath> retained_files_;
     std::vector<base::string16> retained_device_messages_;
 
     DISALLOW_COPY_AND_ASSIGN(Prompt);
   };
 
   static const int kMinExtensionRating = 0;
   static const int kMaxExtensionRating = 5;
 
-  class Delegate {
-   public:
-    // We call this method to signal that the installation should continue.
-    virtual void InstallUIProceed() = 0;
-
-    // We call this method to signal that the installation should stop, with
-    // |user_initiated| true if the installation was stopped by the user.
-    virtual void InstallUIAbort(bool user_initiated) = 0;
-
-   protected:
-    virtual ~Delegate() {}
+  enum class Result {
+    ACCEPTED,
+    USER_CANCELED,
+    ABORTED,
   };
 
+  using DoneCallback = base::Callback<void(Result result)>;
+
   typedef base::Callback<void(ExtensionInstallPromptShowParams*,
-                              ExtensionInstallPrompt::Delegate*,
+                              const DoneCallback&,
                               scoped_ptr<ExtensionInstallPrompt::Prompt>)>
       ShowDialogCallback;
 
   // Callback to show the default extension install dialog.
   // The implementations of this function are platform-specific.
   static ShowDialogCallback GetDefaultShowDialogCallback();
 
   // Returns the appropriate prompt type for the given |extension|.
   // TODO(devlin): This method is yucky - callers probably only care about one
   // prompt type. We just need to comb through and figure out what it is.
@@ skipping 29 matching lines @@
   // null), sets up the Prompt, and calls |show_dialog_callback| when ready to
   // show.
   // |extension| can be null in the case of a bndle install.
   // If |icon| is null, this will attempt to load the extension's icon.
   // |prompt| is used to pass in a prompt with additional data (like retained
   // device permissions) or a different type. If not provided, |prompt| will
   // be created as an INSTALL_PROMPT.
   // |custom_permissions| will be used if provided; otherwise, the extensions
   // current permissions are used.
   //
   // We *MUST* eventually call either Proceed() or Abort() on |delegate|.

[asargent_no_longer_on_chrome, 2015/12/31 00:45:56]

nit: need to update this comment since there's no longer a delegate with
proceed/abort functions

[Devlin, 2016/01/04 22:59:23]

Done.

-  void ShowDialog(Delegate* delegate,
+  void ShowDialog(const DoneCallback& install_callback,
                   const extensions::Extension* extension,
                   const SkBitmap* icon,
                   const ShowDialogCallback& show_dialog_callback);
-  void ShowDialog(Delegate* delegate,
+  void ShowDialog(const DoneCallback& install_callback,
                   const extensions::Extension* extension,
                   const SkBitmap* icon,
                   scoped_ptr<Prompt> prompt,
                   const ShowDialogCallback& show_dialog_callback);
   // Declared virtual for testing purposes.
   // Note: if all you want to do is automatically confirm or cancel, prefer
   // ScopedTestDialogAutoConfirm from extension_dialog_auto_confirm.h
   virtual void ShowDialog(
-      Delegate* delegate,
+      const DoneCallback& install_callback,
       const extensions::Extension* extension,
       const SkBitmap* icon,
       scoped_ptr<Prompt> prompt,
       scoped_ptr<const extensions::PermissionSet> custom_permissions,
       const ShowDialogCallback& show_dialog_callback);
 
   // Installation was successful. This is declared virtual for testing.
   virtual void OnInstallSuccess(const extensions::Extension* extension,
                                 SkBitmap* icon);
 
@@ skipping 38 matching lines @@
   // A custom set of permissions to show in the install prompt instead of the
   // extension's active permissions.
   scoped_ptr<const extensions::PermissionSet> custom_permissions_;
 
   // The object responsible for doing the UI specific actions.
   scoped_ptr<extensions::ExtensionInstallUI> install_ui_;
 
   // Parameters to show the confirmation UI.
   scoped_ptr<ExtensionInstallPromptShowParams> show_params_;
 
-  // The delegate we will call Proceed/Abort on after confirmation UI.
-  Delegate* delegate_;
+  // The callback to run with the result.
+  DoneCallback done_callback_;
 
   // A pre-filled prompt.
   scoped_ptr<Prompt> prompt_;
 
   // Used to show the confirm dialog.
   ShowDialogCallback show_dialog_callback_;
 
   // Whether or not the |show_dialog_callback_| was called.
   bool did_call_show_dialog_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionInstallPrompt);
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_INSTALL_PROMPT_H_