pkg/analysis_server/lib/src/services/completion/dart/suggestion_builder.dart - Issue 1534043002: Cache element docs (and add to completions) (#23694).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart/suggestion_builder.dart

Issue 1534043002: Cache element docs (and add to completions) (#23694). (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: tweaks Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/computer/computer_hover.dart ('k') | pkg/analysis_server/lib/src/utilities/documentation.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/dart/suggestion_builder.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/dart/suggestion_builder.dart b/pkg/analysis_server/lib/src/services/completion/dart/suggestion_builder.dart

index 218cc9f06f7d777b84a2d1ef149b9e2ef256123e..2a537bf072ce120e426fd1e2c20807a13ac1aed6 100644

--- a/pkg/analysis_server/lib/src/services/completion/dart/suggestion_builder.dart

+++ b/pkg/analysis_server/lib/src/services/completion/dart/suggestion_builder.dart

@@ -8,6 +8,7 @@ import 'package:analysis_server/src/protocol_server.dart' as protocol;

import 'package:analysis_server/src/protocol_server.dart'

hide Element, ElementKind;

import 'package:analysis_server/src/provisional/completion/dart/completion_dart.dart';

+import 'package:analysis_server/src/utilities/documentation.dart';

import 'package:analyzer/dart/element/element.dart';

import 'package:analyzer/dart/element/type.dart';

import 'package:analyzer/dart/element/visitor.dart';

@@ -44,6 +45,12 @@ CompletionSuggestion createSuggestion(Element element,

isDeprecated,

false);

+ // Attach docs.

+ String doc = removeDartDocDelimiters(element.documentationComment);

+ suggestion.docComplete = doc;

+ suggestion.docSummary = getDartDocSummary(doc);

suggestion.element = protocol.convertElement(element);

Element enclosingElement = element.enclosingElement;

if (enclosingElement is ClassElement) {