Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 153403004: [Hotword] Add metric to checkbox to track enable/disable of hotwording. (Closed)

Created:
6 years, 10 months ago by rpetterson
Modified:
6 years, 10 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

[Hotword] Add metric to checkbox to track enable/disable of hotwording. BUG=325439, 289023 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250251

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/options/browser_options.html View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 12 (0 generated)
rpetterson
6 years, 10 months ago (2014-02-10 18:49:52 UTC) #1
James Hawkins
lgtm
6 years, 10 months ago (2014-02-10 18:51:40 UTC) #2
rpetterson
The CQ bit was checked by rlp@chromium.org
6 years, 10 months ago (2014-02-10 21:04:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlp@chromium.org/153403004/1
6 years, 10 months ago (2014-02-10 21:05:26 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-10 22:23:56 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=260966
6 years, 10 months ago (2014-02-10 22:23:56 UTC) #6
rpetterson
The CQ bit was checked by rlp@chromium.org
6 years, 10 months ago (2014-02-10 22:32:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlp@chromium.org/153403004/1
6 years, 10 months ago (2014-02-10 22:51:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlp@chromium.org/153403004/1
6 years, 10 months ago (2014-02-10 23:46:22 UTC) #9
commit-bot: I haz the power
Change committed as 250251
6 years, 10 months ago (2014-02-11 00:36:14 UTC) #10
jochen (gone - plz use gerrit)
https://codereview.chromium.org/153403004/diff/1/chrome/browser/resources/options/browser_options.html File chrome/browser/resources/options/browser_options.html (right): https://codereview.chromium.org/153403004/diff/1/chrome/browser/resources/options/browser_options.html#newcode359 chrome/browser/resources/options/browser_options.html:359: metric="Options_HotwordCheckbox" type="checkbox" dialog-pref> you didn't run tools/metrics/actions/extract_actions.py --hash and ...
6 years, 10 months ago (2014-02-12 16:20:56 UTC) #11
rpetterson
6 years, 10 months ago (2014-02-12 18:56:07 UTC) #12
Message was sent while issue was closed. 
https://codereview.chromium.org/153403004/diff/1/chrome/browser/resources/opt...
File chrome/browser/resources/options/browser_options.html (right):

https://codereview.chromium.org/153403004/diff/1/chrome/browser/resources/opt...
chrome/browser/resources/options/browser_options.html:359:
metric="Options_HotwordCheckbox" type="checkbox" dialog-pref>
On 2014/02/12 16:20:56, jochen wrote:
> you didn't run tools/metrics/actions/extract_actions.py --hash and so the
metric
> is not activated.

Thank you for pointing that out! I somehow always forget that step. :-/ I'll
send out another CL.

Powered by Google App Engine
This is Rietveld 408576698