Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 1533963002: add predefines to doxygen (Closed)

Created:
5 years ago by rkotlerimgtec
Modified:
5 years ago
CC:
native-client-reviews_googlegroups.com, rich.fuhler_imgtec.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

add predefines to doxygen this is added for both standard doxygen and clang assisted doxygen (which cannot be turned on yet without some additions to the third-party toolchain but can be used locally). the predefines here are the defaults when subzero is built. not having these creates the bigger issue when clang assisted parsing is enabled but should be there always. BUG= R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=2cad380bd577afd5d230006cdea2b9935744fdaa

Patch Set 1 #

Total comments: 2

Patch Set 2 : change suggested by stichnot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M Doxyfile View 1 2 chunks +16 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
rkotlerimgtec
5 years ago (2015-12-17 19:35:27 UTC) #3
rkotlerimgtec
On 2015/12/17 19:35:27, rkotlerimgtec wrote: Fyi: https://www.stack.nl/~dimitri/doxygen/manual/preprocessing.html https://www.stack.nl/~dimitri/doxygen/manual/config.html#cfg_clang_assisted_parsing
5 years ago (2015-12-17 19:39:47 UTC) #4
Jim Stichnoth
https://codereview.chromium.org/1533963002/diff/1/Doxyfile File Doxyfile (right): https://codereview.chromium.org/1533963002/diff/1/Doxyfile#newcode2328 Doxyfile:2328: "-DPNACL_BROWSER_TRANSLATOR=0" Fix the indentation here to be consistent
5 years ago (2015-12-17 20:32:40 UTC) #5
rkotlerimgtec
https://codereview.chromium.org/1533963002/diff/1/Doxyfile File Doxyfile (right): https://codereview.chromium.org/1533963002/diff/1/Doxyfile#newcode2328 Doxyfile:2328: "-DPNACL_BROWSER_TRANSLATOR=0" On 2015/12/17 20:32:40, stichnot wrote: > Fix the ...
5 years ago (2015-12-17 22:11:33 UTC) #6
Jim Stichnoth
lgtm
5 years ago (2015-12-18 00:31:47 UTC) #7
Jim Stichnoth
5 years ago (2015-12-18 00:32:04 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
2cad380bd577afd5d230006cdea2b9935744fdaa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698