src/core/SkPictureRecord.h - Issue 1533953002: change signature for virtual related to saveLayer, passing SaveLayerRec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkPictureRecord.h

Issue 1533953002: change signature for virtual related to saveLayer, passing SaveLayerRec (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: update comment Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/core/SkPictureRecord.h

diff --git a/src/core/SkPictureRecord.h b/src/core/SkPictureRecord.h

index 3dcaa6ce4c5dda548a5f3dd1a1da5df954b8ec3e..2e1e62a0212426f2b023ba6fc1fc7335a9dd0279 100644

--- a/src/core/SkPictureRecord.h

+++ b/src/core/SkPictureRecord.h

@@ -153,7 +153,7 @@ protected:

bool onPeekPixels(SkPixmap*) override { return false; }

void willSave() override;

- SaveLayerStrategy willSaveLayer(const SkRect*, const SkPaint*, SaveFlags) override;

+ SaveLayerStrategy getSaveLayerStrategy(const SaveLayerRec&) override;

void willRestore() override;

void didConcat(const SkMatrix&) override;

@@ -218,7 +218,7 @@ protected:

size_t recordClipPath(int pathID, SkRegion::Op op, bool doAA);

size_t recordClipRegion(const SkRegion& region, SkRegion::Op op);

void recordSave();

- void recordSaveLayer(const SkRect* bounds, const SkPaint* paint, SaveFlags flags);

+ void recordSaveLayer(const SaveLayerRec&);

void recordRestore(bool fillInSkips = true);

private:

« no previous file with comments | « src/core/SkPicturePlayback.cpp ('k') | src/core/SkPictureRecord.cpp » ('j') | no next file with comments »