Add willBeRemoved and replacedWillBeRemoved deprecation message helpers

Add willBeRemoved and replacedWillBeRemoved deprecation message helpers

The fullscreen deprecation messages are updated, because the old
advice was not as good as the new advice.

R=jochen@chromium.org

Committed: https://crrev.com/4ae0b1c5fb8b3978ebfdb410dd7a3d627fa0693c
Cr-Commit-Position: refs/heads/master@{#366096}

[philipj_slow, 2015-12-18 10:40:21]

The CQ bit was checked by philipj@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2015-12-18 10:40:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1533913003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1533913003/1

[philipj_slow, 2015-12-18 10:40:38]

Description was changed from

==========
Introduce willBeRemoved and replacedWillBeRemoved deprecation message helpers

The fullscreen deprecation messages are updated, because the old
advice was not as good as the new advice.

R=jochen@chromium.org
==========

to

==========
Add willBeRemoved and replacedWillBeRemoved deprecation message helpers

The fullscreen deprecation messages are updated, because the old
advice was not as good as the new advice.

R=jochen@chromium.org
==========

[jochen (gone - plz use gerrit), 2015-12-18 10:43:45]

lgtm

[commit-bot: I haz the power, 2015-12-18 10:50:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-18 10:50:04]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[philipj_slow, 2015-12-18 11:01:54]

add `return nullptr` after ASSERT_NOT_REACHED

[philipj_slow, 2015-12-18 11:02:36]

On 2015/12/18 11:01:54, philipj wrote:
> add `return nullptr` after ASSERT_NOT_REACHED

The win bot was sad because "not all control paths return a value"

[philipj_slow, 2015-12-18 11:02:38]

The CQ bit was checked by philipj@opera.com

[philipj_slow, 2015-12-18 11:02:38]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1533913003/#ps20001
(title: "add `return nullptr` after ASSERT_NOT_REACHED")

[commit-bot: I haz the power, 2015-12-18 11:03:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1533913003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1533913003/20001

[commit-bot: I haz the power, 2015-12-18 12:19:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-18 12:19:22]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[philipj_slow, 2015-12-18 12:32:38]

add missing return

[philipj_slow, 2015-12-18 12:33:16]

The CQ bit was checked by philipj@opera.com

[philipj_slow, 2015-12-18 12:33:16]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1533913003/#ps40001
(title: "add missing return")

[commit-bot: I haz the power, 2015-12-18 12:33:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1533913003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1533913003/40001

[commit-bot: I haz the power, 2015-12-18 14:34:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-18 14:34:15]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[philipj_slow, 2015-12-18 14:41:54]

The CQ bit was checked by philipj@opera.com

[commit-bot: I haz the power, 2015-12-18 14:42:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1533913003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1533913003/40001

[commit-bot: I haz the power, 2015-12-18 15:28:57]

Description was changed from

==========
Add willBeRemoved and replacedWillBeRemoved deprecation message helpers

The fullscreen deprecation messages are updated, because the old
advice was not as good as the new advice.

R=jochen@chromium.org
==========

to

==========
Add willBeRemoved and replacedWillBeRemoved deprecation message helpers

The fullscreen deprecation messages are updated, because the old
advice was not as good as the new advice.

R=jochen@chromium.org
==========

[commit-bot: I haz the power, 2015-12-18 15:28:58]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-18 15:30:06]

Description was changed from

==========
Add willBeRemoved and replacedWillBeRemoved deprecation message helpers

The fullscreen deprecation messages are updated, because the old
advice was not as good as the new advice.

R=jochen@chromium.org
==========

to

==========
Add willBeRemoved and replacedWillBeRemoved deprecation message helpers

The fullscreen deprecation messages are updated, because the old
advice was not as good as the new advice.

R=jochen@chromium.org

Committed: https://crrev.com/4ae0b1c5fb8b3978ebfdb410dd7a3d627fa0693c
Cr-Commit-Position: refs/heads/master@{#366096}
==========

[commit-bot: I haz the power, 2015-12-18 15:30:07]

Patchset 3 (id:??) landed as
https://crrev.com/4ae0b1c5fb8b3978ebfdb410dd7a3d627fa0693c
Cr-Commit-Position: refs/heads/master@{#366096}