Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 1533913003: Add willBeRemoved and replacedWillBeRemoved deprecation message helpers (Closed)

Created:
5 years ago by philipj_slow
Modified:
5 years ago
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add willBeRemoved and replacedWillBeRemoved deprecation message helpers The fullscreen deprecation messages are updated, because the old advice was not as good as the new advice. R=jochen@chromium.org Committed: https://crrev.com/4ae0b1c5fb8b3978ebfdb410dd7a3d627fa0693c Cr-Commit-Position: refs/heads/master@{#366096}

Patch Set 1 #

Patch Set 2 : add `return nullptr` after ASSERT_NOT_REACHED #

Patch Set 3 : add missing return #

Messages

Total messages: 26 (12 generated)
philipj_slow
5 years ago (2015-12-18 10:40:23 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1533913003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1533913003/1
5 years ago (2015-12-18 10:40:33 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years ago (2015-12-18 10:43:45 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/72439)
5 years ago (2015-12-18 10:50:04 UTC) #7
philipj_slow
add `return nullptr` after ASSERT_NOT_REACHED
5 years ago (2015-12-18 11:01:54 UTC) #8
philipj_slow
On 2015/12/18 11:01:54, philipj wrote: > add `return nullptr` after ASSERT_NOT_REACHED The win bot was ...
5 years ago (2015-12-18 11:02:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1533913003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1533913003/20001
5 years ago (2015-12-18 11:03:27 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/151846)
5 years ago (2015-12-18 12:19:22 UTC) #14
philipj_slow
add missing return
5 years ago (2015-12-18 12:32:38 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1533913003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1533913003/40001
5 years ago (2015-12-18 12:33:30 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/158273)
5 years ago (2015-12-18 14:34:15 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1533913003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1533913003/40001
5 years ago (2015-12-18 14:42:25 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-18 15:28:58 UTC) #24
commit-bot: I haz the power
5 years ago (2015-12-18 15:30:07 UTC) #26
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4ae0b1c5fb8b3978ebfdb410dd7a3d627fa0693c
Cr-Commit-Position: refs/heads/master@{#366096}

Powered by Google App Engine
This is Rietveld 408576698