Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 1533873002: Use the unswapped end point y for early out case in winding_line (Closed)

Created:
5 years ago by fs
Modified:
5 years ago
Reviewers:
caryclark, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use the unswapped end point y for early out case in winding_line The x-coordinates are not swapped, so using the swapped y will result in a comparison with the wrong (end) point. BUG=skia:4265 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1533873002 Committed: https://skia.googlesource.com/skia/+/c91065d028472688ce15e635a29abe5256ff89ef

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M src/core/SkPath.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M tests/PathTest.cpp View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1533873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1533873002/1
5 years ago (2015-12-17 14:32:46 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years ago (2015-12-17 14:32:47 UTC) #5
fs
Found via some Blink layout tests.
5 years ago (2015-12-17 14:46:43 UTC) #7
caryclark
lgtm
5 years ago (2015-12-17 16:31:57 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-17 16:32:24 UTC) #10
caryclark
Now I wonder if quads/conics/cubics have the same endpoint bug...
5 years ago (2015-12-17 16:59:21 UTC) #11
fs
On 2015/12/17 at 16:59:21, caryclark wrote: > Now I wonder if quads/conics/cubics have the same ...
5 years ago (2015-12-17 17:02:39 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1533873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1533873002/1
5 years ago (2015-12-17 17:02:55 UTC) #14
commit-bot: I haz the power
5 years ago (2015-12-17 17:03:35 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c91065d028472688ce15e635a29abe5256ff89ef

Powered by Google App Engine
This is Rietveld 408576698