Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(906)

Issue 1533823006: Constant instance creation dependencies also should be computed. (Closed)

Created:
5 years ago by scheglov
Modified:
5 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Constant instance creation dependencies also should be computed. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/17118efd71b69e1648f664a3df536aa66ae79707

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M pkg/analyzer/lib/src/generated/constant.dart View 1 chunk +9 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_test.dart View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
5 years ago (2015-12-17 20:52:18 UTC) #1
Brian Wilkerson
LGTM
5 years ago (2015-12-17 20:58:32 UTC) #2
scheglov
5 years ago (2015-12-17 21:01:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
17118efd71b69e1648f664a3df536aa66ae79707 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698