Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1533823004: Fix owner of mixin forwarding constructors (Closed)

Created:
5 years ago by hausner
Modified:
5 years ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix owner of mixin forwarding constructors Not sure why the new test appears to be a change to existing files, rather than an new files. I'm too dumb for git. BUG=25246 R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/8293e9665b8cf08615098e61236097bfccdedcfd

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -21 lines) Patch
M runtime/vm/class_finalizer.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/class_finalizer.cc View 5 chunks +17 lines, -5 lines 0 comments Download
M runtime/vm/parser.cc View 1 chunk +1 line, -2 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 1 chunk +1 line, -0 lines 0 comments Download
A + tests/language/regress_25246_1_test.dart View 1 1 chunk +5 lines, -1 line 0 comments Download
A + tests/language/regress_25246_2.dart View 1 1 chunk +6 lines, -6 lines 0 comments Download
A + tests/language/regress_25246_3.dart View 1 1 chunk +6 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
hausner
5 years ago (2015-12-17 20:49:54 UTC) #3
regis
LGTM
5 years ago (2015-12-17 22:06:13 UTC) #4
hausner
5 years ago (2015-12-17 22:17:27 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
8293e9665b8cf08615098e61236097bfccdedcfd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698