Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1744)

Issue 1533803002: Revert of [es6] Correct Function.prototype.apply, Reflect.construct and Reflect.apply. (Closed)

Created:
5 years ago by Benedikt Meurer
Modified:
5 years ago
Reviewers:
Yang, paul.l...
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, akos.palfi.imgtec, Paul Lind, v8-arm-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [es6] Correct Function.prototype.apply, Reflect.construct and Reflect.apply. (patchset #5 id:80001 of https://codereview.chromium.org/1523753002/ ) Reason for revert: Breaks TSAN somewhow: http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/7000 Original issue's description: > [es6] Correct Function.prototype.apply, Reflect.construct and Reflect.apply. > > Introduce a new Apply builtin that forms a correct and optimizable > foundation for the Function.prototype.apply, Reflect.construct and > Reflect.apply builtins (which properly does the PrepareForTailCall > as required by the ES2015 spec). > > The new Apply builtin avoids going to the runtime if it is safe to > just access the backing store elements of the argArray, i.e. if you > pass a JSArray with no holes, or an unmapped, unmodified sloppy or > strict arguments object. > > mips/mips64 ports by Balazs Kilvady <balazs.kilvady@imgtec.com>; > > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel > BUG=v8:4413, v8:4430 > LOG=n > R=yangguo@chromium.org > > Committed: https://chromium.googlesource.com/v8/v8/+/e4d2538911f6cb4b626830ccbb3c1f5746542697 TBR=yangguo@chromium.org,paul.lind@imgtec.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4413, v8:4430 Committed: https://crrev.com/567c24d9474cfd4ba49ca200fb9f98cdf4f3d34d Cr-Commit-Position: refs/heads/master@{#32928}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1360 lines, -2075 lines) Patch
M src/arm/builtins-arm.cc View 2 chunks +169 lines, -302 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 2 chunks +186 lines, -312 lines 0 comments Download
M src/bootstrapper.cc View 3 chunks +15 lines, -4 lines 0 comments Download
M src/builtins.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/contexts.h View 1 chunk +8 lines, -3 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 2 chunks +185 lines, -336 lines 0 comments Download
M src/js/runtime.js View 2 chunks +124 lines, -0 lines 0 comments Download
M src/mips/builtins-mips.cc View 3 chunks +174 lines, -327 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 2 chunks +174 lines, -326 lines 0 comments Download
M src/objects.h View 2 chunks +0 lines, -7 lines 0 comments Download
M src/objects.cc View 3 chunks +59 lines, -68 lines 0 comments Download
M src/runtime/runtime.h View 2 chunks +1 line, -3 lines 0 comments Download
M src/runtime/runtime-internal.cc View 3 chunks +1 line, -24 lines 0 comments Download
M src/type-feedback-vector.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/type-feedback-vector.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M src/x64/builtins-x64.cc View 2 chunks +186 lines, -341 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 chunk +33 lines, -0 lines 0 comments Download
M test/mjsunit/apply.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/messages.js View 2 chunks +13 lines, -12 lines 0 comments Download
M test/webkit/fast/js/function-apply.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/function-apply-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Benedikt Meurer
Created Revert of [es6] Correct Function.prototype.apply, Reflect.construct and Reflect.apply.
5 years ago (2015-12-17 08:05:28 UTC) #1
Benedikt Meurer
Committed patchset #1 (id:1) manually as 567c24d9474cfd4ba49ca200fb9f98cdf4f3d34d (tree was closed).
5 years ago (2015-12-17 08:06:49 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-17 08:06:49 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/567c24d9474cfd4ba49ca200fb9f98cdf4f3d34d
Cr-Commit-Position: refs/heads/master@{#32928}

Powered by Google App Engine
This is Rietveld 408576698