Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 15338009: Move workers to Chromium threading (Closed)

Created:
7 years, 7 months ago by abarth-chromium
Modified:
7 years, 7 months ago
Reviewers:
jamesr
CC:
blink-reviews, jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, dglazkov+blink, adamk+blink_chromium.org, haraken, Nate Chapin, darin (slow to review), jamesr
Visibility:
Public.

Description

Prepare to move workers to Chromium threading This CL prepares us to move the underlying thread for web workers from a WTF thread to a Chromium thread. Specifically, this CL removes the notion of a ThreadID from the WorkerThread interface because that notion doesn't exist for Chromium threads. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150815

Patch Set 1 #

Patch Set 2 : Remove extra assert #

Total comments: 2

Patch Set 3 : Revert actual model change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -14 lines) Patch
M Source/bindings/v8/ScheduledAction.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ScriptExecutionContext.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/workers/WorkerContext.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/workers/WorkerMessagingProxy.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/workers/WorkerRunLoop.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/workers/WorkerThread.h View 1 2 3 chunks +6 lines, -5 lines 0 comments Download
M Source/core/workers/WorkerThread.cpp View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M public/platform/WebThread.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
abarth-chromium
7 years, 7 months ago (2013-05-20 20:47:42 UTC) #1
jamesr
lgtm https://codereview.chromium.org/15338009/diff/3001/Source/core/workers/WorkerThread.cpp File Source/core/workers/WorkerThread.cpp (left): https://codereview.chromium.org/15338009/diff/3001/Source/core/workers/WorkerThread.cpp#oldcode181 Source/core/workers/WorkerThread.cpp:181: detachThread(threadID); hmm, should we make an explicit effort ...
7 years, 7 months ago (2013-05-20 20:56:28 UTC) #2
abarth-chromium
https://codereview.chromium.org/15338009/diff/3001/Source/core/workers/WorkerThread.cpp File Source/core/workers/WorkerThread.cpp (left): https://codereview.chromium.org/15338009/diff/3001/Source/core/workers/WorkerThread.cpp#oldcode181 Source/core/workers/WorkerThread.cpp:181: detachThread(threadID); On 2013/05/20 20:56:29, jamesr wrote: > hmm, should ...
7 years, 7 months ago (2013-05-20 21:00:36 UTC) #3
abarth-chromium
Moving the WorkerMessageLoop over is harder than expected because the code commonly uses a pattern ...
7 years, 7 months ago (2013-05-20 22:28:02 UTC) #4
abarth-chromium
I'm reducing this CL to just removing threadID from the WorkerThread interface. I'll change the ...
7 years, 7 months ago (2013-05-21 17:43:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/15338009/9001
7 years, 7 months ago (2013-05-21 17:45:56 UTC) #6
commit-bot: I haz the power
7 years, 7 months ago (2013-05-21 19:08:03 UTC) #7
Message was sent while issue was closed.
Change committed as 150815

Powered by Google App Engine
This is Rietveld 408576698