Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 153373002: Extend PrinterSemanticCapsAndDefaults with Collate, Copies, PaperSize and Dpi capabilities. (Closed)

Created:
6 years, 10 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 10 months ago
Reviewers:
Noam Samuel, gene
CC:
chromium-reviews
Visibility:
Public.

Description

Extend PrinterSemanticCapsAndDefaults with Collate, Copies, PaperSize and Dpi capabilities. BUG=317027 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248842

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Patch Set 4 : removed unnessesary indirection #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -27 lines) Patch
M printing/backend/print_backend.h View 1 2 3 2 chunks +21 lines, -4 lines 0 comments Download
M printing/backend/print_backend.cc View 1 2 3 1 chunk +8 lines, -2 lines 0 comments Download
M printing/backend/print_backend_win.cc View 1 2 3 4 chunks +132 lines, -21 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
Vitaly Buka (NO REVIEWS)
6 years, 10 months ago (2014-02-04 01:48:44 UTC) #1
Vitaly Buka (NO REVIEWS)
6 years, 10 months ago (2014-02-04 01:50:07 UTC) #2
Noam Samuel
lgtm https://codereview.chromium.org/153373002/diff/40002/printing/backend/print_backend_win.cc File printing/backend/print_backend_win.cc (right): https://codereview.chromium.org/153373002/diff/40002/printing/backend/print_backend_win.cc#newcode47 printing/backend/print_backend_win.cc:47: DeviceCapabilities(printer, port, id, Misaligned. https://codereview.chromium.org/153373002/diff/40002/printing/backend/print_backend_win.cc#newcode112 printing/backend/print_backend_win.cc:112: // Add ...
6 years, 10 months ago (2014-02-04 18:33:22 UTC) #3
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/153373002/diff/40002/printing/backend/print_backend_win.cc File printing/backend/print_backend_win.cc (right): https://codereview.chromium.org/153373002/diff/40002/printing/backend/print_backend_win.cc#newcode47 printing/backend/print_backend_win.cc:47: DeviceCapabilities(printer, port, id, On 2014/02/04 18:33:22, Noam Samuel wrote: ...
6 years, 10 months ago (2014-02-04 18:48:24 UTC) #4
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 10 months ago (2014-02-04 18:48:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/153373002/100001
6 years, 10 months ago (2014-02-04 18:49:28 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=223661
6 years, 10 months ago (2014-02-04 21:14:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/153373002/100001
6 years, 10 months ago (2014-02-04 22:31:33 UTC) #8
Vitaly Buka (NO REVIEWS)
The CQ bit was unchecked by vitalybuka@chromium.org
6 years, 10 months ago (2014-02-04 23:13:27 UTC) #9
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 10 months ago (2014-02-04 23:13:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/153373002/100001
6 years, 10 months ago (2014-02-05 01:09:55 UTC) #11
Vitaly Buka (NO REVIEWS)
The CQ bit was unchecked by vitalybuka@chromium.org
6 years, 10 months ago (2014-02-05 01:24:17 UTC) #12
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 10 months ago (2014-02-05 01:48:40 UTC) #13
commit-bot: I haz the power
Commit queue failed due to new patchset.
6 years, 10 months ago (2014-02-05 02:05:16 UTC) #14
Vitaly Buka (NO REVIEWS)
The CQ bit was unchecked by vitalybuka@chromium.org
6 years, 10 months ago (2014-02-05 02:07:40 UTC) #15
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 10 months ago (2014-02-05 02:07:45 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/153373002/510001
6 years, 10 months ago (2014-02-05 03:47:47 UTC) #17
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 04:11:33 UTC) #18
Message was sent while issue was closed. 
Change committed as 248842

Powered by Google App Engine
This is Rietveld 408576698