Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 1533723002: [turbofan] More thorough validation of LiveRanges. (Closed)

Created:
5 years ago by Mircea Trofin
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] More thorough validation of LiveRanges. Added structural validation to live ranges, esp. for bugs that may arise due to splintering / merging. BUG= Committed: https://crrev.com/6e8065a5065d201098a79fc2828c48eaf7e33fc6 Cr-Commit-Position: refs/heads/master@{#32954}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -6 lines) Patch
M src/compiler/register-allocator.h View 3 chunks +10 lines, -1 line 0 comments Download
M src/compiler/register-allocator.cc View 1 5 chunks +35 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Mircea Trofin
5 years ago (2015-12-17 01:37:10 UTC) #3
Jarin
Nice, thanks. lgtm.
5 years ago (2015-12-17 08:53:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1533723002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1533723002/40001
5 years ago (2015-12-17 15:27:55 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-17 15:29:18 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-17 15:29:46 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6e8065a5065d201098a79fc2828c48eaf7e33fc6
Cr-Commit-Position: refs/heads/master@{#32954}

Powered by Google App Engine
This is Rietveld 408576698