Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Unified Diff: sql/meta_table.cc

Issue 1533703002: [sql] Consider fresh databases suitable for memory-mapped I/O. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sql/meta_table.cc
diff --git a/sql/meta_table.cc b/sql/meta_table.cc
index 319f73d24db60396d5b9e16148a4388ffb265825..011fe18acfb7ee1891778ece58e3bbd2f1f6a615 100644
--- a/sql/meta_table.cc
+++ b/sql/meta_table.cc
@@ -13,9 +13,10 @@
namespace {
-// Key used in our meta table for version numbers.
+// Keys understood directly by sql:MetaTable.
const char kVersionKey[] = "version";
const char kCompatibleVersionKey[] = "last_compatible_version";
+const char kMmapStatusKey[] = "mmap_status";
// Used to track success/failure of deprecation checks.
enum DeprecationEventType {
@@ -59,12 +60,41 @@ MetaTable::~MetaTable() {
}
// static
+int64_t MetaTable::kMmapFailure = -2;
+int64_t MetaTable::kMmapSuccess = -1;
+
+// static
bool MetaTable::DoesTableExist(sql::Connection* db) {
DCHECK(db);
return db->DoesTableExist("meta");
}
// static
+bool MetaTable::GetMmapStatus(Connection* db, int64_t* status) {
+ const char* kMmapStatusSql = "SELECT value FROM meta WHERE key = ?";
+ Statement s(db->GetUniqueStatement(kMmapStatusSql));
+ if (!s.is_valid())
+ return false;
+
+ // It is fine for the status to be missing entirely, but any error prevents
+ // memory-mapping.
+ s.BindString(0, kMmapStatusKey);
+ *status = s.Step() ? s.ColumnInt64(0) : 0;
+ return s.Succeeded();
+}
+
+// static
+bool MetaTable::SetMmapStatus(Connection* db, int64_t status) {
+ DCHECK(status == kMmapFailure || status == kMmapSuccess || status >= 0);
+
+ const char* kMmapUpdateStatusSql = "REPLACE INTO meta VALUES (?, ?)";
+ Statement s(db->GetUniqueStatement(kMmapUpdateStatusSql));
+ s.BindString(0, kMmapStatusKey);
+ s.BindInt64(1, status);
+ return s.Run();
+}
+
+// static
void MetaTable::RazeIfDeprecated(Connection* db, int deprecated_version) {
DCHECK_GT(deprecated_version, 0);
DCHECK_EQ(0, db->transaction_nesting());
@@ -131,6 +161,10 @@ bool MetaTable::Init(Connection* db, int version, int compatible_version) {
"(key LONGVARCHAR NOT NULL UNIQUE PRIMARY KEY, value LONGVARCHAR)"))
return false;
+ // Newly-created databases start out with mmap'ed I/O, but have no place to
+ // store the setting. Set here so that later opens don't need to validate.
+ SetMmapStatus(db_, kMmapSuccess);
+
// Note: there is no index over the meta table. We currently only have a
// couple of keys, so it doesn't matter. If we start storing more stuff in
// there, we should create an index.

Powered by Google App Engine
This is Rietveld 408576698