pkg/analyzer/lib/src/codegen/tools.dart - Issue 1533693003: - Fix usage of Platform.packageRoot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/codegen/tools.dart

Issue 1533693003: - Fix usage of Platform.packageRoot. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: sync to latest Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analyzer/lib/src/codegen/tools.dart

diff --git a/pkg/analyzer/lib/src/codegen/tools.dart b/pkg/analyzer/lib/src/codegen/tools.dart

index 6c4048c90ef2a0ceedfaf82587ec6332c56ba1b2..1c96ef09de66c4ce2e113a0198f4f63b7e8c3d9d 100644

--- a/pkg/analyzer/lib/src/codegen/tools.dart

+++ b/pkg/analyzer/lib/src/codegen/tools.dart

@@ -311,7 +311,7 @@ abstract class GeneratedContent {

print('Please regenerate using:');

String executable = Platform.executable;

String packageRoot = '';

- if (Platform.packageRoot.isNotEmpty) {

+ if (Platform.packageRoot != null) {

packageRoot = ' --package-root=${Platform.packageRoot}';

}

String generateScript =