third_party/WebKit/Source/core/dom/Node.h - Issue 1533683002: Persist invalidation sets on detach root

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Node.h

Issue 1533683002: Persist invalidation sets on detach root (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Avoid detaching when in inactive state Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Node.h

diff --git a/third_party/WebKit/Source/core/dom/Node.h b/third_party/WebKit/Source/core/dom/Node.h

index db272ce5fe2288385157134c65a27510fbfb9126..2410b54fee968e7a780282fdca1529e32f009890 100644

--- a/third_party/WebKit/Source/core/dom/Node.h

+++ b/third_party/WebKit/Source/core/dom/Node.h

@@ -522,10 +522,11 @@ public:

struct AttachContext {

STACK_ALLOCATED();

- ComputedStyle* resolvedStyle;

- bool performingReattach;

+ ComputedStyle* resolvedStyle = nullptr;

+ bool performingReattach = false;

+ bool clearInvalidation = false;

- AttachContext() : resolvedStyle(nullptr), performingReattach(false) { }

+ AttachContext() { }

};

// Attaches this node to the layout tree. This calculates the style to be applied to the node and creates an