Add SourceReport, a class for generating Dart source-level reports.

Add SourceReport, a class for generating Dart source-level reports.

These reports provide information tied to token positions in the
Dart source program.

SourceReport can generate multiple kinds of reports.  Right now it
implements code coverage and call site reports.  In the future it
could provide, for example, valid breakpoint sites or source-level
profiles.

Scripts are refered to by index within the report and a script table
is tacked on the end.  This avoids a bit of duplication.

In a future cl I will expose this reporting through the vm service.
After that, we can remove our older coverage/callsite code.

----------
Very simple, sample coverage report:

{
  "type": "SourceReport",
  "ranges": [
    {
      "scriptIndex": 0,
      "startPos": 0,
      "endPos": 4,
      "compiled": true,
      "coverage": {
        "hits": [],
        "misses": []
      }
    },
    {
      "scriptIndex": 0,
      "startPos": 6,
      "endPos": 10,
      "compiled": false
    },
    {
      "scriptIndex": 0,
      "startPos": 12,
      "endPos": 39,
      "compiled": true,
      "coverage": {
        "hits": [ 23 ],
        "misses": [ 32 ]
      }
    }
  ],
  "scripts": [
    {
      "type": "@Script",
      "fixedId": true,
      "id": "libraries\/15\/scripts\/test-lib",
      "uri": "test-lib",
      "_kind": "script"
    }
  ]
}

R=johnmccutchan@google.com

Committed: https://github.com/dart-lang/sdk/commit/26af34a1b3a912f16f52c69723ca99789d88153b

[turnidge, 2015-12-17 20:38:32]

turnidge@google.com changed reviewers:
+ johnmccutchan@google.com

[Cutch, 2015-12-17 21:31:07]

https://codereview.chromium.org/1533653003/diff/20001/runtime/vm/source_repor...
File runtime/vm/source_report.cc (right):

https://codereview.chromium.org/1533653003/diff/20001/runtime/vm/source_repor...
runtime/vm/source_report.cc:95: const Library& lib) {
indent two spaces

https://codereview.chromium.org/1533653003/diff/20001/runtime/vm/source_repor...
runtime/vm/source_report.cc:174: if (count > 0) {
Maybe add a variable:

const intptr_t relative_token_pos = token_pos - begin_pos;

and use that instead of the expression everywhere.

https://codereview.chromium.org/1533653003/diff/20001/runtime/vm/source_repor...
runtime/vm/source_report.cc:223: if (func.HasCode() || compile_mode_ ==
kForceCompile) {
(compile_mode_ == kForceCompile)

https://codereview.chromium.org/1533653003/diff/20001/runtime/vm/source_repor...
runtime/vm/source_report.cc:314: const Script& script,
indent two spaces

https://codereview.chromium.org/1533653003/diff/20001/runtime/vm/source_repor...
runtime/vm/source_report.cc:330: if (ScriptIsLoadedByLibrary(script, lib)) {
This function and ::PrintJSON seem like they could be folded into one. 

Maybe by making ScriptIsLoadedByLibrary return true when script is null.

https://codereview.chromium.org/1533653003/diff/20001/runtime/vm/source_report.h
File runtime/vm/source_report.h (right):

https://codereview.chromium.org/1533653003/diff/20001/runtime/vm/source_repor...
runtime/vm/source_report.h:64: key = NULL;
use initializer list syntax instead..
: key(NULL)...

[turnidge, 2015-12-17 21:48:01]

PTAL

https://codereview.chromium.org/1533653003/diff/20001/runtime/vm/source_repor...
File runtime/vm/source_report.cc (right):

https://codereview.chromium.org/1533653003/diff/20001/runtime/vm/source_repor...
runtime/vm/source_report.cc:95: const Library& lib) {
On 2015/12/17 21:31:06, Cutch wrote:
> indent two spaces

Done.

https://codereview.chromium.org/1533653003/diff/20001/runtime/vm/source_repor...
runtime/vm/source_report.cc:174: if (count > 0) {
On 2015/12/17 21:31:06, Cutch wrote:
> Maybe add a variable:
> 
> const intptr_t relative_token_pos = token_pos - begin_pos;
> 
> and use that instead of the expression everywhere.

Ok.  Added "token_offset".

https://codereview.chromium.org/1533653003/diff/20001/runtime/vm/source_repor...
runtime/vm/source_report.cc:223: if (func.HasCode() || compile_mode_ ==
kForceCompile) {
On 2015/12/17 21:31:06, Cutch wrote:
> (compile_mode_ == kForceCompile)

Done.

https://codereview.chromium.org/1533653003/diff/20001/runtime/vm/source_repor...
runtime/vm/source_report.cc:314: const Script& script,
On 2015/12/17 21:31:06, Cutch wrote:
> indent two spaces

Done.

https://codereview.chromium.org/1533653003/diff/20001/runtime/vm/source_repor...
runtime/vm/source_report.cc:330: if (ScriptIsLoadedByLibrary(script, lib)) {
On 2015/12/17 21:31:06, Cutch wrote:
> This function and ::PrintJSON seem like they could be folded into one. 
> 
> Maybe by making ScriptIsLoadedByLibrary return true when script is null.

Ok, merged them into one function.

https://codereview.chromium.org/1533653003/diff/20001/runtime/vm/source_report.h
File runtime/vm/source_report.h (right):

https://codereview.chromium.org/1533653003/diff/20001/runtime/vm/source_repor...
runtime/vm/source_report.h:64: key = NULL;
On 2015/12/17 21:31:07, Cutch wrote:
> use initializer list syntax instead..
> : key(NULL)...

Done.

[Cutch, 2015-12-17 21:50:04]

lgtm

[turnidge, 2016-01-04 18:56:55]

Description was changed from

==========
Add SourceReport, a class for generating Dart source-level reports.

These reports provide information tied to token positions in the
Dart source program.

SourceReport can generate multiple kinds of reports.  Right now it
implements code coverage and call site reports.  In the future it
could provide, for example, valid breakpoint sites or source-level
profiles.

Scripts are refered to by index within the report and a script table
is tacked on the end.  This avoids a bit of duplication.

In a future cl I will expose this reporting through the vm service.
After that, we can remove our older coverage/callsite code.

----------
Very simple, sample coverage report:

{
  "type": "SourceReport",
  "ranges": [
    {
      "scriptIndex": 0,
      "startPos": 0,
      "endPos": 4,
      "compiled": true,
      "coverage": {
        "hits": [],
        "misses": []
      }
    },
    {
      "scriptIndex": 0,
      "startPos": 6,
      "endPos": 10,
      "compiled": false
    },
    {
      "scriptIndex": 0,
      "startPos": 12,
      "endPos": 39,
      "compiled": true,
      "coverage": {
        "hits": [ 23 ],
        "misses": [ 32 ]
      }
    }
  ],
  "scripts": [
    {
      "type": "@Script",
      "fixedId": true,
      "id": "libraries\/15\/scripts\/test-lib",
      "uri": "test-lib",
      "_kind": "script"
    }
  ]
}
==========

to

==========
Add SourceReport, a class for generating Dart source-level reports.

These reports provide information tied to token positions in the
Dart source program.

SourceReport can generate multiple kinds of reports.  Right now it
implements code coverage and call site reports.  In the future it
could provide, for example, valid breakpoint sites or source-level
profiles.

Scripts are refered to by index within the report and a script table
is tacked on the end.  This avoids a bit of duplication.

In a future cl I will expose this reporting through the vm service.
After that, we can remove our older coverage/callsite code.

----------
Very simple, sample coverage report:

{
  "type": "SourceReport",
  "ranges": [
    {
      "scriptIndex": 0,
      "startPos": 0,
      "endPos": 4,
      "compiled": true,
      "coverage": {
        "hits": [],
        "misses": []
      }
    },
    {
      "scriptIndex": 0,
      "startPos": 6,
      "endPos": 10,
      "compiled": false
    },
    {
      "scriptIndex": 0,
      "startPos": 12,
      "endPos": 39,
      "compiled": true,
      "coverage": {
        "hits": [ 23 ],
        "misses": [ 32 ]
      }
    }
  ],
  "scripts": [
    {
      "type": "@Script",
      "fixedId": true,
      "id": "libraries\/15\/scripts\/test-lib",
      "uri": "test-lib",
      "_kind": "script"
    }
  ]
}

R=johnmccutchan@google.com

Committed:
https://github.com/dart-lang/sdk/commit/26af34a1b3a912f16f52c69723ca99789d88153b
==========

[turnidge, 2016-01-04 18:56:57]

Committed patchset #4 (id:60001) manually as
26af34a1b3a912f16f52c69723ca99789d88153b (presubmit successful).