Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 1533653002: Import the baseURI test from web-platform-tests (Closed)

Created:
5 years ago by philipj_slow
Modified:
5 years ago
Reviewers:
tkent, fs
CC:
chromium-reviews, blink-reviews, tfarina, blink-reviews-w3ctests_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Import the baseURI test from web-platform-tests Import web-platform-tests@0bb3d73f26aa5a21326b6c1c7aaf35029222223f Using update-w3c-deps in Blink 731a1238920ae9b7216cd2ced12267deb0d63e19. This fails, but is imported so that it can be fixed. BUG=570679 Committed: https://crrev.com/504d39f51972ae114ddfb97656ca0a009b911d16 Cr-Commit-Position: refs/heads/master@{#365828}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/W3CImportExpectations View 1 chunk +0 lines, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/dom/nodes/Node-baseURI.html View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1533653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1533653002/1
5 years ago (2015-12-16 21:46:25 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-16 22:44:34 UTC) #4
philipj_slow
PTAL
5 years ago (2015-12-17 15:21:28 UTC) #7
philipj_slow
Next CL is https://codereview.chromium.org/1529363004/
5 years ago (2015-12-17 15:22:02 UTC) #8
philipj_slow
The way this test fails is: This is a testharness.js-based test. PASS For elements belonging ...
5 years ago (2015-12-17 15:31:24 UTC) #9
fs
LGTM On 2015/12/17 at 15:22:02, philipj wrote: > Next CL is https://codereview.chromium.org/1529363004/ Why not land ...
5 years ago (2015-12-17 15:33:54 UTC) #10
philipj_slow
On 2015/12/17 15:33:54, fs wrote: > LGTM > > On 2015/12/17 at 15:22:02, philipj wrote: ...
5 years ago (2015-12-17 15:35:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1533653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1533653002/1
5 years ago (2015-12-17 15:36:26 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-17 15:40:47 UTC) #15
commit-bot: I haz the power
5 years ago (2015-12-17 15:42:03 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/504d39f51972ae114ddfb97656ca0a009b911d16
Cr-Commit-Position: refs/heads/master@{#365828}

Powered by Google App Engine
This is Rietveld 408576698