Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 1533593003: X87: Change the test case for X87 RunFloat64Add and RunFloat64Sub (Closed)

Created:
5 years ago by zhengxing.li
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Change the test case for X87 RunFloat64Add and RunFloat64Sub The CL #32908 (https://codereview.chromium.org/1526293002) updated the Float64 test data and cause the RunFloat64Add and RunFloat64Sub test cases failed. The reason is same as the CL #31808 (issue 1430943002, X87: Change the test case for X87 float operations), please refer: https://codereview.chromium.org/1430943002/ Here is the key comments from CL #31808 Some new test cases use CheckFloatEq(...) and CheckDoubleEq(...) function for result check. When GCC compiling the CheckFloatEq() and CheckDoubleEq() function, those inlined functions has different behavior comparing with GCC ia32 build and x87 build. The major difference is sse float register still has single precision rounding semantic. While X87 register has no such rounding precsion semantic when directly use register value. The V8 turbofan JITTed has exactly same result in both X87 and IA32 port. So we add the following sentence to do type case to keep the same precision for RunFloat64Add and RunFloat64Sub. Such as: volatile double expect = *i +/- *j; // *i +/- *j, etc. BUG= Committed: https://crrev.com/dd31b080f2383f8a9dbdbb9235f76c3154690af5 Cr-Commit-Position: refs/heads/master@{#32988}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M test/cctest/compiler/test-run-machops.cc View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
zhengxing.li
5 years ago (2015-12-17 10:05:52 UTC) #2
ahaas
lgtm
5 years ago (2015-12-17 10:16:24 UTC) #3
Weiliang
lgtm
5 years ago (2015-12-18 01:15:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1533593003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1533593003/1
5 years ago (2015-12-18 01:15:08 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/9124)
5 years ago (2015-12-18 01:21:13 UTC) #8
zhengxing.li
5 years ago (2015-12-18 02:15:24 UTC) #10
zhengxing.li
5 years ago (2015-12-18 12:10:00 UTC) #12
ahaas
lgtm
5 years ago (2015-12-21 10:44:17 UTC) #13
zhengxing.li
On 2015/12/21 10:44:17, ahaas wrote: > lgtm Hi, ahaas: Thanks for your lgtm again. This ...
5 years ago (2015-12-21 14:48:55 UTC) #14
Jarin
lgtm
5 years ago (2015-12-21 15:05:38 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1533593003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1533593003/1
5 years ago (2015-12-21 15:06:45 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-21 15:49:46 UTC) #18
commit-bot: I haz the power
5 years ago (2015-12-21 15:49:52 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dd31b080f2383f8a9dbdbb9235f76c3154690af5
Cr-Commit-Position: refs/heads/master@{#32988}

Powered by Google App Engine
This is Rietveld 408576698