Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(931)

Unified Diff: content/browser/download/download_create_info.cc

Issue 1533583002: [Downloads] Factor out request handling logic between DRH and UD. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments and change .Pass() -> std::move(...) per PRESUBMIT check Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/download/download_create_info.h ('k') | content/browser/download/download_manager_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/download/download_create_info.cc
diff --git a/content/browser/download/download_create_info.cc b/content/browser/download/download_create_info.cc
index 05b0992a26dc31035362b263ae6ada37ef5fbcf2..901d3d86d4e184c5fdf015660453bca43a00b9b8 100644
--- a/content/browser/download/download_create_info.cc
+++ b/content/browser/download/download_create_info.cc
@@ -14,39 +14,32 @@ namespace content {
DownloadCreateInfo::DownloadCreateInfo(const base::Time& start_time,
int64 total_bytes,
const net::BoundNetLog& bound_net_log,
- bool has_user_gesture,
- ui::PageTransition transition_type,
scoped_ptr<DownloadSaveInfo> save_info)
: start_time(start_time),
total_bytes(total_bytes),
download_id(DownloadItem::kInvalidId),
- has_user_gesture(has_user_gesture),
- transition_type(transition_type),
+ has_user_gesture(false),
+ transition_type(ui::PAGE_TRANSITION_LINK),
save_info(save_info.Pass()),
request_bound_net_log(bound_net_log) {}
DownloadCreateInfo::DownloadCreateInfo()
- : total_bytes(0),
- download_id(DownloadItem::kInvalidId),
- has_user_gesture(false),
- transition_type(ui::PAGE_TRANSITION_LINK),
- save_info(new DownloadSaveInfo()) {
-}
+ : DownloadCreateInfo(base::Time(),
+ 0,
+ net::BoundNetLog(),
+ make_scoped_ptr(new DownloadSaveInfo)) {}
-DownloadCreateInfo::~DownloadCreateInfo() {
-}
+DownloadCreateInfo::~DownloadCreateInfo() {}
std::string DownloadCreateInfo::DebugString() const {
- return base::StringPrintf("{"
- " download_id = %u"
- " url = \"%s\""
- " request_handle = %s"
- " total_bytes = %" PRId64
- " }",
- download_id,
- url().spec().c_str(),
- request_handle.DebugString().c_str(),
- total_bytes);
+ return base::StringPrintf(
+ "{"
+ " download_id = %u"
+ " url = \"%s\""
+ " request_handle = %s"
+ " total_bytes = %" PRId64 " }",
+ download_id, url().spec().c_str(), request_handle->DebugString().c_str(),
+ total_bytes);
}
const GURL& DownloadCreateInfo::url() const {
« no previous file with comments | « content/browser/download/download_create_info.h ('k') | content/browser/download/download_manager_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698