[turbofan] Fixed the second return value of TryTruncateFloatXXToUint64.

[turbofan] Fixed the second return value of TryTruncateFloatXXToUint64.

As required by the spec, the second return value now returns success
also for the range between 0 and -1 where the conversion results in 0.

R=bradnelson@chromium.org, mstarzinger@chromium.org, v8-arm-ports@googlegroups.com, v8-mips-ports@googlegroups.com

Committed: https://crrev.com/0794c3c9b9a05b4fa95df2f7ec68d17e2b012611
Cr-Commit-Position: refs/heads/master@{#32936}

[jbramley, 2015-12-16 12:49:37]

jacob.bramley@arm.com changed reviewers:
+ jacob.bramley@arm.com

[jbramley, 2015-12-16 12:49:37]

Out of curiosity, which specification are you referring to?

https://codereview.chromium.org/1533503002/diff/1/src/compiler/arm64/code-gen...
File src/compiler/arm64/code-generator-arm64.cc (right):

https://codereview.chromium.org/1533503002/diff/1/src/compiler/arm64/code-gen...
src/compiler/arm64/code-generator-arm64.cc:1063: __
Fcmp(i.InputFloat32Register(0), -1.0);
Is -1.0 supposed to be inclusive? If not, "ge" needs to be "gt".

[Michael Starzinger, 2015-12-16 12:57:21]

LGTM (rubber-stamped "compiler", don't know the details behind the change).

[ahaas, 2015-12-16 16:15:25]

https://codereview.chromium.org/1533503002/diff/1/src/compiler/arm64/code-gen...
File src/compiler/arm64/code-generator-arm64.cc (right):

https://codereview.chromium.org/1533503002/diff/1/src/compiler/arm64/code-gen...
src/compiler/arm64/code-generator-arm64.cc:1063: __
Fcmp(i.InputFloat32Register(0), -1.0);
On 2015/12/16 at 12:49:37, jbramley wrote:
> Is -1.0 supposed to be inclusive? If not, "ge" needs to be "gt".

done. I added a test for this case too.

[jbramley, 2015-12-16 16:19:03]

LGTM (arm64)

[ahaas, 2015-12-17 10:23:11]

The CQ bit was checked by ahaas@chromium.org

[ahaas, 2015-12-17 10:23:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1533503002/#ps20001
(title: "Code cleanup")

[commit-bot: I haz the power, 2015-12-17 10:23:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1533503002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1533503002/20001

[commit-bot: I haz the power, 2015-12-17 10:24:41]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-17 10:25:04]

Description was changed from

==========
[turbofan] Fixed the second return value of TryTruncateFloatXXToUint64.

As required by the spec, the second return value now returns success
also for the range between 0 and -1 where the conversion results in 0.

R=bradnelson@chromium.org, mstarzinger@chromium.org,
v8-arm-ports@googlegroups.com, v8-mips-ports@googlegroups.com
==========

to

==========
[turbofan] Fixed the second return value of TryTruncateFloatXXToUint64.

As required by the spec, the second return value now returns success
also for the range between 0 and -1 where the conversion results in 0.

R=bradnelson@chromium.org, mstarzinger@chromium.org,
v8-arm-ports@googlegroups.com, v8-mips-ports@googlegroups.com

Committed: https://crrev.com/0794c3c9b9a05b4fa95df2f7ec68d17e2b012611
Cr-Commit-Position: refs/heads/master@{#32936}
==========

[commit-bot: I haz the power, 2015-12-17 10:25:05]

Patchset 2 (id:??) landed as
https://crrev.com/0794c3c9b9a05b4fa95df2f7ec68d17e2b012611
Cr-Commit-Position: refs/heads/master@{#32936}

[ahaas, 2015-12-21 09:26:41]

On 2015/12/16 at 12:49:37, jacob.bramley wrote:
> Out of curiosity, which specification are you referring to?
> 
>
https://codereview.chromium.org/1533503002/diff/1/src/compiler/arm64/code-gen...
> File src/compiler/arm64/code-generator-arm64.cc (right):
> 
>
https://codereview.chromium.org/1533503002/diff/1/src/compiler/arm64/code-gen...
> src/compiler/arm64/code-generator-arm64.cc:1063: __
Fcmp(i.InputFloat32Register(0), -1.0);
> Is -1.0 supposed to be inclusive? If not, "ge" needs to be "gt".

Sorry that I reply so late. I am talking about the web-assembly specification
(https://github.com/WebAssembly/spec)