Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 1533423003: [turbofan] Remove some dead code in move optimizer. (Closed)

Created:
5 years ago by Mircea Trofin
Modified:
5 years ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove some dead code in move optimizer. There was no use for the second temp vector, and the one we are using is scoped to certain methods, and that scope can be further restricted. I'm curious if there is really any value in having the temp vector instead of allocating a function-scoped local. Will verify that separately. Committed: https://crrev.com/d33b8f20d5e44f3e6cc7b86c6b02d5f64f20994b Cr-Commit-Position: refs/heads/master@{#32998}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -21 lines) Patch
M src/compiler/move-optimizer.h View 2 chunks +3 lines, -6 lines 0 comments Download
M src/compiler/move-optimizer.cc View 6 chunks +14 lines, -15 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Mircea Trofin
5 years ago (2015-12-22 02:22:05 UTC) #6
Benedikt Meurer
LGTM.
5 years ago (2015-12-22 05:53:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1533423003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1533423003/60001
5 years ago (2015-12-22 06:36:47 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:60001)
5 years ago (2015-12-22 06:37:56 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-22 06:38:10 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d33b8f20d5e44f3e6cc7b86c6b02d5f64f20994b
Cr-Commit-Position: refs/heads/master@{#32998}

Powered by Google App Engine
This is Rietveld 408576698