Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1533383004: Explicitly enable the use of init/fini array under PNaCl (Closed)

Created:
5 years ago by Petr Hosek
Modified:
4 years, 10 months ago
Reviewers:
Derek Schuff
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/nacl-newlib.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Explicitly enable the use of init/fini array under PNaCl Newlib relies on configure time check to determine and enable init/fini array support. However, this check uses readelf which does not work for PNaCl; pnacl-readelf gets around this issue by explicitly hardcoding this case. This change explicitly enables the use of init/fini array under PNaCl which does not rely on pnacl-readelf support and works even with the native Clang PNaCl driver. BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4347 R=dschuff@chromium.org Committed: https://git.chromium.org/gitweb?p=native_client/nacl-newlib.git;a=commit;h=784956835fd318fa64e513ead7774d897386a7be

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M newlib/libc/misc/fini.c View 1 chunk +1 line, -1 line 0 comments Download
M newlib/libc/misc/init.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
Petr Hosek
5 years ago (2015-12-22 02:13:08 UTC) #2
Petr Hosek
5 years ago (2015-12-22 02:13:43 UTC) #5
Derek Schuff
lgtm
4 years, 11 months ago (2016-01-20 19:27:03 UTC) #8
Petr Hosek
4 years, 10 months ago (2016-01-28 20:40:28 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
784956835fd318fa64e513ead7774d897386a7be (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698