Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Unified Diff: runtime/lib/object.cc

Issue 1533383003: Remove instantiator argument in generated code for type tests. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: fix typo Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/lib/object_patch.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/object.cc
diff --git a/runtime/lib/object.cc b/runtime/lib/object.cc
index d8693a1bb0a75002f0e84de7b5db5d7d9fd40974..72fcc3e394a8d77a0b7101452f4add4704cd0798 100644
--- a/runtime/lib/object.cc
+++ b/runtime/lib/object.cc
@@ -155,17 +155,14 @@ static void WarnOnJSIntegralNumTypeTest(
}
-DEFINE_NATIVE_ENTRY(Object_instanceOf, 5) {
+DEFINE_NATIVE_ENTRY(Object_instanceOf, 4) {
const Instance& instance =
Instance::CheckedHandle(zone, arguments->NativeArgAt(0));
- // Instantiator at position 1 is not used. It is passed along so that the call
- // can be easily converted to an optimized implementation. Instantiator is
- // used to populate the subtype cache.
const TypeArguments& instantiator_type_arguments =
- TypeArguments::CheckedHandle(zone, arguments->NativeArgAt(2));
+ TypeArguments::CheckedHandle(zone, arguments->NativeArgAt(1));
const AbstractType& type =
- AbstractType::CheckedHandle(zone, arguments->NativeArgAt(3));
- const Bool& negate = Bool::CheckedHandle(zone, arguments->NativeArgAt(4));
+ AbstractType::CheckedHandle(zone, arguments->NativeArgAt(2));
+ const Bool& negate = Bool::CheckedHandle(zone, arguments->NativeArgAt(3));
ASSERT(type.IsFinalized());
ASSERT(!type.IsMalformed());
ASSERT(!type.IsMalbounded());
@@ -267,15 +264,12 @@ DEFINE_NATIVE_ENTRY(Object_instanceOfString, 2) {
}
-DEFINE_NATIVE_ENTRY(Object_as, 4) {
+DEFINE_NATIVE_ENTRY(Object_as, 3) {
const Instance& instance = Instance::CheckedHandle(arguments->NativeArgAt(0));
- // Instantiator at position 1 is not used. It is passed along so that the call
- // can be easily converted to an optimized implementation. Instantiator is
- // used to populate the subtype cache.
const TypeArguments& instantiator_type_arguments =
- TypeArguments::CheckedHandle(arguments->NativeArgAt(2));
+ TypeArguments::CheckedHandle(arguments->NativeArgAt(1));
const AbstractType& type =
- AbstractType::CheckedHandle(arguments->NativeArgAt(3));
+ AbstractType::CheckedHandle(arguments->NativeArgAt(2));
ASSERT(type.IsFinalized());
ASSERT(!type.IsMalformed());
ASSERT(!type.IsMalbounded());
« no previous file with comments | « no previous file | runtime/lib/object_patch.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698