Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1533383003: Remove instantiator argument in generated code for type tests. (Closed)

Created:
5 years ago by regis
Modified:
5 years ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove instantiator argument in generated code for type tests. R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/48bc8bbf330d476850cae0e65001096793d46504

Patch Set 1 #

Patch Set 2 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -286 lines) Patch
M runtime/lib/object.cc View 2 chunks +7 lines, -13 lines 0 comments Download
M runtime/lib/object_patch.dart View 2 chunks +2 lines, -5 lines 0 comments Download
M runtime/vm/bootstrap_natives.h View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/code_generator.cc View 5 chunks +16 lines, -24 lines 0 comments Download
M runtime/vm/constant_propagator.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/flow_graph_builder.h View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 8 chunks +13 lines, -39 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 9 chunks +21 lines, -25 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm64.cc View 9 chunks +14 lines, -27 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 9 chunks +6 lines, -17 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 9 chunks +28 lines, -37 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 9 chunks +6 lines, -17 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 10 chunks +8 lines, -17 lines 0 comments Download
M runtime/vm/il_printer.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M runtime/vm/intermediate_language.h View 6 chunks +6 lines, -13 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 3 chunks +5 lines, -8 lines 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 3 chunks +5 lines, -8 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 3 chunks +5 lines, -8 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 3 chunks +5 lines, -8 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 3 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
regis
5 years ago (2015-12-21 19:32:14 UTC) #2
srdjan
lgtm
5 years ago (2015-12-21 20:44:07 UTC) #3
regis
5 years ago (2015-12-21 21:07:39 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
48bc8bbf330d476850cae0e65001096793d46504 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698