Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1533363002: GN: Remove asset_location parameter in favour of android_assets() (Closed)

Created:
5 years ago by agrieve
Modified:
5 years ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@asset-location-1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Remove asset_location parameter in favour of android_assets() BUG=547162 Committed: https://crrev.com/e37dbc81379a6018ee85e260daa95da750fabfa1 Cr-Commit-Position: refs/heads/master@{#366747}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -17 lines) Patch
M build/config/android/internal_rules.gni View 2 chunks +0 lines, -13 lines 0 comments Download
M build/config/android/rules.gni View 1 chunk +0 lines, -1 line 0 comments Download
M testing/test.gni View 1 chunk +0 lines, -3 lines 0 comments Download

Depends on Patchset:

Issue 1533353002 Patch 1

Messages

Total messages: 8 (3 generated)
agrieve
❇ ❈ ❊
5 years ago (2015-12-21 16:35:37 UTC) #2
Dirk Pranke
lgtm
5 years ago (2015-12-23 04:04:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1533363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1533363002/1
5 years ago (2015-12-23 14:47:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-23 15:22:16 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-23 15:23:04 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e37dbc81379a6018ee85e260daa95da750fabfa1
Cr-Commit-Position: refs/heads/master@{#366747}

Powered by Google App Engine
This is Rietveld 408576698