Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(812)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1533343002: GN: Fix cronet compile with enable_incremental_javac = true (Closed)

Created:
5 years ago by agrieve
Modified:
5 years ago
Reviewers:
mef
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Fix cronet compile with enable_incremental_javac = true jmake requires directory to match java package name. BUG= Committed: https://crrev.com/b4ec4cb8227302ed4ce218818b3479a43e6143c9 Cr-Commit-Position: refs/heads/master@{#366415}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/cronet/android/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
agrieve
※ ※ ※
5 years ago (2015-12-21 16:25:17 UTC) #2
mef
lgtm
5 years ago (2015-12-21 16:51:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1533343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1533343002/1
5 years ago (2015-12-21 17:12:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-21 17:50:26 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-21 17:51:47 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b4ec4cb8227302ed4ce218818b3479a43e6143c9
Cr-Commit-Position: refs/heads/master@{#366415}

Powered by Google App Engine
This is Rietveld 408576698