Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 153333002: [NaCl SDK Docs] Update CSS for docs. (Closed)

Created:
6 years, 10 months ago by binji
Modified:
6 years, 10 months ago
Reviewers:
Sam Clegg, Andy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, native-client-reviews_googlegroups.com, Sam Clegg, extensions-reviews_chromium.org
Visibility:
Public.

Description

[NaCl SDK Docs] Update CSS for docs. * Add a top-level <div> with id "doxygen-ref", to more easily match only doxygen-generated elements. This is the same behavior as with devsite. * Also add doxygen.css, which is minimal so far; it mostly just cleans up the table layout. * Also removing the local_extensions.css file. It was only used for local testing make the generated pages look more like devsite. BUG=none R=awatson@chromium.org, sbc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249462

Patch Set 1 #

Total comments: 3

Patch Set 2 : reuse CSS from local_extensions #

Total comments: 4

Patch Set 3 : remove some more CSS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+360 lines, -406 lines) Patch
M chrome/common/extensions/docs/templates/private/standard_nacl_article.html View 1 1 chunk +1 line, -0 lines 0 comments Download
D native_client_sdk/src/doc/_static/css/local_extensions.css View 1 chunk +0 lines, -404 lines 0 comments Download
A native_client_sdk/src/doc/_static/css/nacl.css View 1 2 1 chunk +354 lines, -0 lines 0 comments Download
M native_client_sdk/src/doc/doxygen/footer.html View 1 chunk +1 line, -0 lines 0 comments Download
M native_client_sdk/src/doc/doxygen/header.html View 1 1 chunk +3 lines, -1 line 0 comments Download
M native_client_sdk/src/doc/index.rst View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
binji
https://codereview.chromium.org/153333002/diff/1/native_client_sdk/src/doc/doxygen/header.html File native_client_sdk/src/doc/doxygen/header.html (right): https://codereview.chromium.org/153333002/diff/1/native_client_sdk/src/doc/doxygen/header.html#newcode5 native_client_sdk/src/doc/doxygen/header.html:5: {{- dummy div to appease doxygen -}} {{- ...
6 years, 10 months ago (2014-02-04 01:05:31 UTC) #1
Sam Clegg
lgtm, What is that huge .css file you are deleting?
6 years, 10 months ago (2014-02-04 01:32:56 UTC) #2
binji
I believe that is CSS that made the docs look more like devsite when serving ...
6 years, 10 months ago (2014-02-04 17:18:08 UTC) #3
Andy
https://codereview.chromium.org/153333002/diff/1/native_client_sdk/src/doc/_static/css/local_extensions.css File native_client_sdk/src/doc/_static/css/local_extensions.css (left): https://codereview.chromium.org/153333002/diff/1/native_client_sdk/src/doc/_static/css/local_extensions.css#oldcode5 native_client_sdk/src/doc/_static/css/local_extensions.css:5: /* GENERAL */ Some of these styles are used ...
6 years, 10 months ago (2014-02-04 18:50:38 UTC) #4
binji
https://codereview.chromium.org/153333002/diff/1/native_client_sdk/src/doc/_static/css/local_extensions.css File native_client_sdk/src/doc/_static/css/local_extensions.css (left): https://codereview.chromium.org/153333002/diff/1/native_client_sdk/src/doc/_static/css/local_extensions.css#oldcode5 native_client_sdk/src/doc/_static/css/local_extensions.css:5: /* GENERAL */ On 2014/02/04 18:50:39, Andy wrote: > ...
6 years, 10 months ago (2014-02-04 22:01:48 UTC) #5
Andy
LGTM. A couple of small suggestions inline for styles that are safe to delete. https://codereview.chromium.org/153333002/diff/80001/native_client_sdk/src/doc/_static/css/nacl.css ...
6 years, 10 months ago (2014-02-05 00:30:06 UTC) #6
binji
https://codereview.chromium.org/153333002/diff/80001/native_client_sdk/src/doc/_static/css/nacl.css File native_client_sdk/src/doc/_static/css/nacl.css (right): https://codereview.chromium.org/153333002/diff/80001/native_client_sdk/src/doc/_static/css/nacl.css#newcode35 native_client_sdk/src/doc/_static/css/nacl.css:35: /* VERSION INFORMATION */ On 2014/02/05 00:30:08, Andy wrote: ...
6 years, 10 months ago (2014-02-05 01:41:44 UTC) #7
binji
6 years, 10 months ago (2014-02-06 18:48:39 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 manually as r249462 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698