Issue 1533323004: Support narrowing a timeline to a given time window

Issue 1533323004: Support narrowing a timeline to a given time window (Closed)

Created:
5 years ago by Cutch

Modified:
5 years ago

Reviewers:
siva

CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Support narrowing a timeline to a given time window - Assign correct timestamps for timeline events from Dart code. - Support optional 'timeOriginMicros' and 'timeExtentMicros' to _getVMTimeline service RPC. - Relax time extent check in profiler. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/bedd2cbf25644f8a76cb45937522245c15201373

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+108 lines, -17 lines)			Patch
M	runtime/lib/timeline.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/observatory/tests/service/get_vm_timeline_rpc_test.dart	View		3 chunks	+43 lines, -0 lines	0 comments	Download
M	runtime/vm/profiler.h	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	runtime/vm/profiler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/service.cc	View		2 chunks	+7 lines, -1 line	0 comments	Download
M	runtime/vm/timeline.h	View	1	3 chunks	+13 lines, -3 lines	0 comments	Download
M	runtime/vm/timeline.cc	View	1	5 chunks	+37 lines, -8 lines	0 comments	Download

Total messages: 6 (3 generated)

Cutch

5 years ago (2015-12-22 17:18:49 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
bedd2cbf25644f8a76cb45937522245c15201373 (presubmit successful).