Rewrite double.parse.

runtime/lib/string_patch.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 patch class String {
   /* patch */ factory String.fromCharCodes(Iterable<int> charCodes) {
     return _StringBase.createFromCharCodes(charCodes);
   }
 }
 
@@ skipping 493 matching lines @@
   static final int _classId = "A"._cid;
 
   factory _OneByteString._uninstantiable() {
     throw new UnsupportedError(
         "_OneByteString can only be allocated by the VM");
   }
 
   int get hashCode native "String_getHashCode";
 
   // Checks for one-byte whitespaces only.
-  // TODO(srdjan): Investigate if 0x85 (NEL) and 0xA0 (NBSP) are valid
-  // whitespaces for one byte strings.
   bool _isWhitespace(int codePoint) {
     return
       (codePoint == 32) || // Space.
-      ((9 <= codePoint) && (codePoint <= 13)); // CR, LF, TAB, etc.
+      ((9 <= codePoint) && (codePoint <= 13)) ||  // CR, LF, TAB, etc.
+      (codePoint == 0xA0);  // NBSP.
   }
 
   String _substringUncheckedNative(int startIndex, int endIndex)
       native "OneByteString_substringUnchecked";
 
   List<String> _splitWithCharCode(int charCode)
       native "OneByteString_splitWithCharCode";
 
   List<String> split(Pattern pattern) {
     if ((pattern._cid == _OneByteString._classId) && (pattern.length == 1)) {
@@ skipping 31 matching lines @@
   void _setAt(int index, int codePoint) native "OneByteString_setAt";
 }
 
 
 class _TwoByteString extends _StringBase implements String {
   factory _TwoByteString._uninstantiable() {
     throw new UnsupportedError(
         "_TwoByteString can only be allocated by the VM");
   }
 
-  // Checks for one-byte whitespaces only.
-  // TODO(srdjan): Investigate if 0x85 (NEL) and 0xA0 (NBSP) are valid
-  // whitespaces. Add checking for multi-byte whitespace codepoints.
+  // Characters in the Zl category:
+  //  U+0020  SPACE
+  //  U+00A0  NO-BREAK SPACE
+  //  U+1680  OGHAM SPACE MARK
+  //  U+180E  MONGOLIAN VOWEL SEPARATOR
+  //  U+2000  EN QUAD
+  //  U+2001  EM QUAD
+  //  U+2002  EN SPACE
+  //  U+2003  EM SPACE
+  //  U+2004  THREE-PER-EM SPACE
+  //  U+2005  FOUR-PER-EM SPACE
+  //  U+2006  SIX-PER-EM SPACE
+  //  U+2007  FIGURE SPACE
+  //  U+2008  PUNCTUATION SPACE
+  //  U+2009  THIN SPACE
+  //  U+200A  HAIR SPACE
+  //  U+202F  NARROW NO-BREAK SPACE
+  //  U+205F  MEDIUM MATHEMATICAL SPACE
+  //  U+3000  IDEOGRAPHIC SPACE
+  //
+  // Characters in the Zl category: 0x2028
+  // Characters in the Zp category: 0x2029
+  // BOM: 0xFEFF
   bool _isWhitespace(int codePoint) {
     return
-      (codePoint == 32) || // Space.
-      ((9 <= codePoint) && (codePoint <= 13)); // CR, LF, TAB, etc.
+        (codePoint == 32) || // Space.
+        ((9 <= codePoint) && (codePoint <= 13)) || // CR, LF, TAB, etc.
+        (codePoint == 0xA0) ||  // NBSP.
+        // Characters in the Zs category:
+        (codePoint == 0x1680) ||
+        (codePoint == 0x180E) ||
+        ((0x2000 <= codePoint) && (codePoint <= 0x200A)) ||
+        (codePoint == 0x202F) ||
+        (codePoint == 0x205F) ||
+        (codePoint == 0x3000) ||
+        (codePoint == 0x2028) ||
+        (codePoint == 0x2029) ||
+        (codePoint == 0xFEFF);
   }
 }
 
 
 class _FourByteString extends _StringBase implements String {
   factory _FourByteString._uninstantiable() {
     throw new UnsupportedError(
         "_FourByteString can only be allocated by the VM");
   }
 
-  // Checks for one-byte whitespaces only.
-  // TODO(srdjan): Investigate if 0x85 (NEL) and 0xA0 (NBSP) are valid
-  // whitespaces. Add checking for multi-byte whitespace codepoints.
   bool _isWhitespace(int codePoint) {
     return
-      (codePoint == 32) || // Space.
-      ((9 <= codePoint) && (codePoint <= 13)); // CR, LF, TAB, etc.
+        (codePoint == 32) || // Space.
+        ((9 <= codePoint) && (codePoint <= 13)) || // CR, LF, TAB, etc.
+        (codePoint == 0xA0) ||  // NBSP.
+        // Characters in the Zs category:
+        (codePoint == 0x1680) ||
+        (codePoint == 0x180E) ||
+        ((0x2000 <= codePoint) && (codePoint <= 0x200A)) ||
+        (codePoint == 0x202F) ||
+        (codePoint == 0x205F) ||
+        (codePoint == 0x3000) ||
+        (codePoint == 0x2028) ||
+        (codePoint == 0x2029) ||
+        (codePoint == 0xFEFF);
   }
 }
 
 
 class _ExternalOneByteString extends _StringBase implements String {
   factory _ExternalOneByteString._uninstantiable() {
     throw new UnsupportedError(
         "_ExternalOneByteString can only be allocated by the VM");
   }
 
   // Checks for one-byte whitespaces only.
-  // TODO(srdjan): Investigate if 0x85 (NEL) and 0xA0 (NBSP) are valid
-  // whitespaces for one byte strings.
   bool _isWhitespace(int codePoint) {
     return
       (codePoint == 32) || // Space.
-      ((9 <= codePoint) && (codePoint <= 13)); // CR, LF, TAB, etc.
+      ((9 <= codePoint) && (codePoint <= 13)) || // CR, LF, TAB, etc.
+      (codePoint == 0xA0);  // NBSP.
   }
 }
 
 
 class _ExternalTwoByteString extends _StringBase implements String {
   factory _ExternalTwoByteString._uninstantiable() {
     throw new UnsupportedError(
         "_ExternalTwoByteString can only be allocated by the VM");
   }
 
-  // Checks for one-byte whitespaces only.
-  // TODO(srdjan): Investigate if 0x85 (NEL) and 0xA0 (NBSP) are valid
-  // whitespaces. Add checking for multi-byte whitespace codepoints.
   bool _isWhitespace(int codePoint) {
     return
-      (codePoint == 32) || // Space.
-      ((9 <= codePoint) && (codePoint <= 13)); // CR, LF, TAB, etc.
+        (codePoint == 32) || // Space.
+        ((9 <= codePoint) && (codePoint <= 13)) || // CR, LF, TAB, etc.
+        (codePoint == 0xA0) ||  // NBSP.
+        // Characters in the Zs category:
+        (codePoint == 0x1680) ||
+        (codePoint == 0x180E) ||
+        ((0x2000 <= codePoint) && (codePoint <= 0x200A)) ||
+        (codePoint == 0x202F) ||
+        (codePoint == 0x205F) ||
+        (codePoint == 0x3000) ||
+        (codePoint == 0x2028) ||
+        (codePoint == 0x2029) ||
+        (codePoint == 0xFEFF);
   }
 }
 
 
 class _StringMatch implements Match {
   const _StringMatch(int this.start,
                      String this.str,
                      String this.pattern);
 
   int get end => start + pattern.length;
@@ skipping 26 matching lines @@
 class _CodeUnits extends Object with ListMixin<int>,
                                      UnmodifiableListMixin<int> {
   /** The string that this is the code units of. */
   String _string;
 
   _CodeUnits(this._string);
 
   int get length => _string.length;
   int operator[](int i) => _string.codeUnitAt(i);
 }