Mac: Don't create shortcuts for hosted apps when they are installed

Mac: Don't create shortcuts for hosted apps when they are installed

Most noticeably, default apps like Drive, YouTube, etc. appear on
chrome://apps and are downloaded and "installed" whenever a new profile
is created, and so were getting shortcuts created on Mac.

For shortcut creation, Chrome doesn't currently distinguish these
"default" installs from things installed from the WebStore. But the
logic on Mac was incorrectly triggering shortcut creation for all hosted
app installs, which differs from other platforms. On other platforms,
shortcuts for hosted apps can only created via chrome://apps, or the
bookmark app flow.

This has been for happening for new profile creations on Mac since
r316113 (m42), since it caused web_app::ShouldCreateShortcutFor()  to
unconditionally return `true` even for automated codepaths.

To fix, skip creation of these hosted app shortcuts on Mac when
triggered by AppShortcutManager::OnExtensionWillBeInstalled() by making
web_app::ShouldCreateShortcutFor(..) more closely follow other
platforms.

However, Mac has the problem that shortcuts can break, and require
repair, across Chrome versions. To address this, use custom logic in
web_app_mac.mm rather than relying on
web_app::ShouldCreateShortcutFor(..) for determining what to upgrade,
and ensure shortcuts are not newly created during a batch upgrade.

When the default app is downloaded and installed on profile creation, a
user can still create a shortcut for these by going to chrome://apps and
selecting "Create Shortcut..." from the context menu.

BUG=571310
TEST=On Mac, create a new profile. Nothing new should appear in
`~Applications/Chrome Apps`. (Note this needs an official build: default
apps are not installed for Chromium).

Committed: https://crrev.com/e5f2cd2dffa0dba08561b04032c8a6221e73826c
Cr-Commit-Position: refs/heads/master@{#369325}

[tapted, 2015-12-21 04:26:09]

Description was changed from

==========
Mac: Don't create shortcuts for default apps on profile creation

Default apps like Drive, YouTube, etc. appear on chrome://apps and are
downloaded and "installed" whenever a new profile is created.

For shortcut creation, Chrome doesn't currently distinguish these installs from
things installed from the webstore, and so shortcuts are created for them on
all platforms. This is acceptable on Windows, but "shortcuts" on Mac are not as
lightweight and appear more prominently in the system. This has been
happening on Mac since r316113 (m42).

To fix, skip creation of these shortcuts on Mac when the default app is
downloaded and installed on profile creation. A user can still create a
shortcut for these by going to chrome://apps and selecting "Create
Shortcut..." from the context menu.

BUG=571310
TEST=On Mac, create a new profile. Nothing new should appear in
`~Applications/Chrome Apps`.
(Note this needs an official build: default apps are not installed for
Chromium).
==========

to

==========
Mac: Don't create shortcuts for default apps on profile creation

Default apps like Drive, YouTube, etc. appear on chrome://apps and are
downloaded and "installed" whenever a new profile is created.

For shortcut creation, Chrome doesn't currently distinguish these
installs from things installed from the WebStore, and so shortcuts are
created for them on all platforms. This is acceptable on Windows, but
"shortcuts" on Mac are not as lightweight and appear more prominently in
the system.

This has been for happening for new profile creations on Mac since
r316113 (m42).

To fix, skip creation of these shortcuts on Mac when the default app is
downloaded and installed on profile creation. A user can still create a
shortcut for these by going to chrome://apps and selecting "Create
Shortcut..." from the context menu.

BUG=571310
TEST=On Mac, create a new profile. Nothing new should appear in
`~Applications/Chrome Apps`. (Note this needs an official build: default
apps are not installed for Chromium).
==========

[tapted, 2015-12-21 05:00:42]

Patchset #2 (id:20001) has been deleted

[tapted, 2015-12-21 07:34:16]

Description was changed from

==========
Mac: Don't create shortcuts for default apps on profile creation

Default apps like Drive, YouTube, etc. appear on chrome://apps and are
downloaded and "installed" whenever a new profile is created.

For shortcut creation, Chrome doesn't currently distinguish these
installs from things installed from the WebStore, and so shortcuts are
created for them on all platforms. This is acceptable on Windows, but
"shortcuts" on Mac are not as lightweight and appear more prominently in
the system.

This has been for happening for new profile creations on Mac since
r316113 (m42).

To fix, skip creation of these shortcuts on Mac when the default app is
downloaded and installed on profile creation. A user can still create a
shortcut for these by going to chrome://apps and selecting "Create
Shortcut..." from the context menu.

BUG=571310
TEST=On Mac, create a new profile. Nothing new should appear in
`~Applications/Chrome Apps`. (Note this needs an official build: default
apps are not installed for Chromium).
==========

to

==========
Mac: Don't create shortcuts for hosted apps when they are installed

Most noticeably, default apps like Drive, YouTube, etc. appear on chrome://apps
and are
downloaded and "installed" whenever a new profile is created, and
so were getting shortcuts created on Mac.

For shortcut creation, Chrome doesn't currently distinguish these "default"
installs from things installed from the WebStore. But the logic on Mac
was incorrectly triggering shortcut creation for all hosted app installs,
which differs from other platforms.

This has been for happening for new profile creations on Mac since
r316113 (m42).

To fix, skip creation of these hosted app shortcuts on Mac.

<more>


when the default app is
downloaded and installed on profile creation. A user can still create a
shortcut for these by going to chrome://apps and selecting "Create
Shortcut..." from the context menu.

BUG=571310
TEST=On Mac, create a new profile. Nothing new should appear in
`~Applications/Chrome Apps`. (Note this needs an official build: default
apps are not installed for Chromium).
==========

[tapted, 2015-12-21 07:35:39]

Description was changed from

==========
Mac: Don't create shortcuts for hosted apps when they are installed

Most noticeably, default apps like Drive, YouTube, etc. appear on chrome://apps
and are
downloaded and "installed" whenever a new profile is created, and
so were getting shortcuts created on Mac.

For shortcut creation, Chrome doesn't currently distinguish these "default"
installs from things installed from the WebStore. But the logic on Mac
was incorrectly triggering shortcut creation for all hosted app installs,
which differs from other platforms.

This has been for happening for new profile creations on Mac since
r316113 (m42).

To fix, skip creation of these hosted app shortcuts on Mac.

<more>


when the default app is
downloaded and installed on profile creation. A user can still create a
shortcut for these by going to chrome://apps and selecting "Create
Shortcut..." from the context menu.

BUG=571310
TEST=On Mac, create a new profile. Nothing new should appear in
`~Applications/Chrome Apps`. (Note this needs an official build: default
apps are not installed for Chromium).
==========

to

==========
Mac: Don't create shortcuts for hosted apps when they are installed

Most noticeably, default apps like Drive, YouTube, etc. appear on
chrome://apps and are downloaded and "installed" whenever a new profile
is created, and so were getting shortcuts created on Mac.

For shortcut creation, Chrome doesn't currently distinguish these
"default" installs from things installed from the WebStore. But the
logic on Mac was incorrectly triggering shortcut creation for all hosted
app installs, which differs from other platforms. On other platforms,
shortcuts for hosted apps can only created via chrome://apps, or the
bookmark app flow.

This has been for happening for new profile creations on Mac since
r316113 (m42).

To fix, skip creation of these hosted app shortcuts on Mac.

<more>

when the default app is downloaded and installed on profile creation. A
user can still create a shortcut for these by going to chrome://apps and
selecting "Create Shortcut..." from the context menu.

BUG=571310
TEST=On Mac, create a new profile. Nothing new should appear in
`~Applications/Chrome Apps`. (Note this needs an official build: default
apps are not installed for Chromium).
==========

[tapted, 2016-01-13 05:35:42]

Patchset #5 (id:100001) has been deleted

[tapted, 2016-01-13 06:19:33]

Description was changed from

==========
Mac: Don't create shortcuts for hosted apps when they are installed

Most noticeably, default apps like Drive, YouTube, etc. appear on
chrome://apps and are downloaded and "installed" whenever a new profile
is created, and so were getting shortcuts created on Mac.

For shortcut creation, Chrome doesn't currently distinguish these
"default" installs from things installed from the WebStore. But the
logic on Mac was incorrectly triggering shortcut creation for all hosted
app installs, which differs from other platforms. On other platforms,
shortcuts for hosted apps can only created via chrome://apps, or the
bookmark app flow.

This has been for happening for new profile creations on Mac since
r316113 (m42).

To fix, skip creation of these hosted app shortcuts on Mac.

<more>

when the default app is downloaded and installed on profile creation. A
user can still create a shortcut for these by going to chrome://apps and
selecting "Create Shortcut..." from the context menu.

BUG=571310
TEST=On Mac, create a new profile. Nothing new should appear in
`~Applications/Chrome Apps`. (Note this needs an official build: default
apps are not installed for Chromium).
==========

to

==========
Mac: Don't create shortcuts for hosted apps when they are installed

Most noticeably, default apps like Drive, YouTube, etc. appear on
chrome://apps and are downloaded and "installed" whenever a new profile
is created, and so were getting shortcuts created on Mac.

For shortcut creation, Chrome doesn't currently distinguish these
"default" installs from things installed from the WebStore. But the
logic on Mac was incorrectly triggering shortcut creation for all hosted
app installs, which differs from other platforms. On other platforms,
shortcuts for hosted apps can only created via chrome://apps, or the
bookmark app flow.

This has been for happening for new profile creations on Mac since
r316113 (m42), since it caused web_app::ShouldCreateShortcutFor()  to
unconditionally return `true` even for automated codepaths.

To fix, skip creation of these hosted app shortcuts on Mac when
triggered by AppShortcutManager::OnExtensionWillBeInstalled() by making
web_app::ShouldCreateShortcutFor(..) more closely follow other
platforms.

However, Mac has the problem that shortcuts can break, and require
repair, across Chrome versions. To address this, use custom logic in
web_app_mac.mm rather than relying on
web_app::ShouldCreateShortcutFor(..) for determining what to upgrade,
and ensure shortcuts are not newly created during a batch upgrade.

When the default app is downloaded and installed on profile creation, a
user can still create a shortcut for these by going to chrome://apps and
selecting "Create Shortcut..." from the context menu.

BUG=571310
TEST=On Mac, create a new profile. Nothing new should appear in
`~Applications/Chrome Apps`. (Note this needs an official build: default
apps are not installed for Chromium).
==========

[tapted, 2016-01-13 06:19:33]

tapted@chromium.org changed reviewers:
+ dominickn@chromium.org

[tapted, 2016-01-13 06:22:47]

Hi Dom, please take a look. I think this is the next step in fixing all these
bugs, and this one is most important for m49. Next steps: 
- better testing (http://crrev.com/1549673002 -- doesn't make sense to do this
along with / before this CL since this fix still can't get proper coverage due
to the g_app_shims_allow_update_and_launch_in_tests stuff -- that needs to be
removed first).
- http://crbug.com/571550 -- I'm leaving that one for you :)

[dominickn, 2016-01-14 00:39:23]

On 2016/01/13 06:22:47, tapted wrote:
> Hi Dom, please take a look. I think this is the next step in fixing all these
> bugs, and this one is most important for m49. Next steps: 
> - better testing (http://crrev.com/1549673002 -- doesn't make sense to do this
> along with / before this CL since this fix still can't get proper coverage due
> to the g_app_shims_allow_update_and_launch_in_tests stuff -- that needs to be
> removed first).
> - http://crbug.com/571550 -- I'm leaving that one for you :)

lgtm - will be looking at crbug.com/571550 asap

[tapted, 2016-01-14 02:48:26]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2016-01-14 02:49:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1533273002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1533273002/160001

[commit-bot: I haz the power, 2016-01-14 04:37:44]

Description was changed from

==========
Mac: Don't create shortcuts for hosted apps when they are installed

Most noticeably, default apps like Drive, YouTube, etc. appear on
chrome://apps and are downloaded and "installed" whenever a new profile
is created, and so were getting shortcuts created on Mac.

For shortcut creation, Chrome doesn't currently distinguish these
"default" installs from things installed from the WebStore. But the
logic on Mac was incorrectly triggering shortcut creation for all hosted
app installs, which differs from other platforms. On other platforms,
shortcuts for hosted apps can only created via chrome://apps, or the
bookmark app flow.

This has been for happening for new profile creations on Mac since
r316113 (m42), since it caused web_app::ShouldCreateShortcutFor()  to
unconditionally return `true` even for automated codepaths.

To fix, skip creation of these hosted app shortcuts on Mac when
triggered by AppShortcutManager::OnExtensionWillBeInstalled() by making
web_app::ShouldCreateShortcutFor(..) more closely follow other
platforms.

However, Mac has the problem that shortcuts can break, and require
repair, across Chrome versions. To address this, use custom logic in
web_app_mac.mm rather than relying on
web_app::ShouldCreateShortcutFor(..) for determining what to upgrade,
and ensure shortcuts are not newly created during a batch upgrade.

When the default app is downloaded and installed on profile creation, a
user can still create a shortcut for these by going to chrome://apps and
selecting "Create Shortcut..." from the context menu.

BUG=571310
TEST=On Mac, create a new profile. Nothing new should appear in
`~Applications/Chrome Apps`. (Note this needs an official build: default
apps are not installed for Chromium).
==========

to

==========
Mac: Don't create shortcuts for hosted apps when they are installed

Most noticeably, default apps like Drive, YouTube, etc. appear on
chrome://apps and are downloaded and "installed" whenever a new profile
is created, and so were getting shortcuts created on Mac.

For shortcut creation, Chrome doesn't currently distinguish these
"default" installs from things installed from the WebStore. But the
logic on Mac was incorrectly triggering shortcut creation for all hosted
app installs, which differs from other platforms. On other platforms,
shortcuts for hosted apps can only created via chrome://apps, or the
bookmark app flow.

This has been for happening for new profile creations on Mac since
r316113 (m42), since it caused web_app::ShouldCreateShortcutFor()  to
unconditionally return `true` even for automated codepaths.

To fix, skip creation of these hosted app shortcuts on Mac when
triggered by AppShortcutManager::OnExtensionWillBeInstalled() by making
web_app::ShouldCreateShortcutFor(..) more closely follow other
platforms.

However, Mac has the problem that shortcuts can break, and require
repair, across Chrome versions. To address this, use custom logic in
web_app_mac.mm rather than relying on
web_app::ShouldCreateShortcutFor(..) for determining what to upgrade,
and ensure shortcuts are not newly created during a batch upgrade.

When the default app is downloaded and installed on profile creation, a
user can still create a shortcut for these by going to chrome://apps and
selecting "Create Shortcut..." from the context menu.

BUG=571310
TEST=On Mac, create a new profile. Nothing new should appear in
`~Applications/Chrome Apps`. (Note this needs an official build: default
apps are not installed for Chromium).
==========

[commit-bot: I haz the power, 2016-01-14 04:37:44]

Committed patchset #7 (id:160001)

[commit-bot: I haz the power, 2016-01-14 04:38:33]

Description was changed from

==========
Mac: Don't create shortcuts for hosted apps when they are installed

Most noticeably, default apps like Drive, YouTube, etc. appear on
chrome://apps and are downloaded and "installed" whenever a new profile
is created, and so were getting shortcuts created on Mac.

For shortcut creation, Chrome doesn't currently distinguish these
"default" installs from things installed from the WebStore. But the
logic on Mac was incorrectly triggering shortcut creation for all hosted
app installs, which differs from other platforms. On other platforms,
shortcuts for hosted apps can only created via chrome://apps, or the
bookmark app flow.

This has been for happening for new profile creations on Mac since
r316113 (m42), since it caused web_app::ShouldCreateShortcutFor()  to
unconditionally return `true` even for automated codepaths.

To fix, skip creation of these hosted app shortcuts on Mac when
triggered by AppShortcutManager::OnExtensionWillBeInstalled() by making
web_app::ShouldCreateShortcutFor(..) more closely follow other
platforms.

However, Mac has the problem that shortcuts can break, and require
repair, across Chrome versions. To address this, use custom logic in
web_app_mac.mm rather than relying on
web_app::ShouldCreateShortcutFor(..) for determining what to upgrade,
and ensure shortcuts are not newly created during a batch upgrade.

When the default app is downloaded and installed on profile creation, a
user can still create a shortcut for these by going to chrome://apps and
selecting "Create Shortcut..." from the context menu.

BUG=571310
TEST=On Mac, create a new profile. Nothing new should appear in
`~Applications/Chrome Apps`. (Note this needs an official build: default
apps are not installed for Chromium).
==========

to

==========
Mac: Don't create shortcuts for hosted apps when they are installed

Most noticeably, default apps like Drive, YouTube, etc. appear on
chrome://apps and are downloaded and "installed" whenever a new profile
is created, and so were getting shortcuts created on Mac.

For shortcut creation, Chrome doesn't currently distinguish these
"default" installs from things installed from the WebStore. But the
logic on Mac was incorrectly triggering shortcut creation for all hosted
app installs, which differs from other platforms. On other platforms,
shortcuts for hosted apps can only created via chrome://apps, or the
bookmark app flow.

This has been for happening for new profile creations on Mac since
r316113 (m42), since it caused web_app::ShouldCreateShortcutFor()  to
unconditionally return `true` even for automated codepaths.

To fix, skip creation of these hosted app shortcuts on Mac when
triggered by AppShortcutManager::OnExtensionWillBeInstalled() by making
web_app::ShouldCreateShortcutFor(..) more closely follow other
platforms.

However, Mac has the problem that shortcuts can break, and require
repair, across Chrome versions. To address this, use custom logic in
web_app_mac.mm rather than relying on
web_app::ShouldCreateShortcutFor(..) for determining what to upgrade,
and ensure shortcuts are not newly created during a batch upgrade.

When the default app is downloaded and installed on profile creation, a
user can still create a shortcut for these by going to chrome://apps and
selecting "Create Shortcut..." from the context menu.

BUG=571310
TEST=On Mac, create a new profile. Nothing new should appear in
`~Applications/Chrome Apps`. (Note this needs an official build: default
apps are not installed for Chromium).

Committed: https://crrev.com/e5f2cd2dffa0dba08561b04032c8a6221e73826c
Cr-Commit-Position: refs/heads/master@{#369325}
==========

[commit-bot: I haz the power, 2016-01-14 04:38:34]

Patchset 7 (id:??) landed as
https://crrev.com/e5f2cd2dffa0dba08561b04032c8a6221e73826c
Cr-Commit-Position: refs/heads/master@{#369325}