Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp

Issue 1533233002: Fix JS seconds since epoch to date conversions. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master
Patch Set: more test cases Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « fpdfsdk/src/javascript/public_methods_embeddertest.cpp ('k') | pdfium.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 PDFium Authors. All rights reserved. 1 // Copyright 2015 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/include/fpdfapi/fpdf_parser.h" 5 #include "testing/js_embedder_test.h"
6 #include "fpdfsdk/include/jsapi/fxjs_v8.h"
7 #include "testing/embedder_test.h"
8 #include "testing/gtest/include/gtest/gtest.h" 6 #include "testing/gtest/include/gtest/gtest.h"
9 #include "third_party/base/nonstd_unique_ptr.h"
10 7
11 namespace { 8 namespace {
12 9
13 const wchar_t kScript[] = L"fred = 7"; 10 const wchar_t kScript[] = L"fred = 7";
14 11
15 } // namespace 12 } // namespace
16 13
17 class FXJSV8Embeddertest : public EmbedderTest { 14 class FXJSV8EmbedderTest : public JSEmbedderTest {};
18 public:
19 FXJSV8Embeddertest()
20 : m_pArrayBufferAllocator(new FXJS_ArrayBufferAllocator) {
21 v8::Isolate::CreateParams params;
22 params.array_buffer_allocator = m_pArrayBufferAllocator.get();
23 m_pIsolate = v8::Isolate::New(params);
24 }
25 15
26 ~FXJSV8Embeddertest() override { m_pIsolate->Dispose(); } 16 TEST_F(FXJSV8EmbedderTest, Getters) {
27
28 void SetUp() override {
29 EmbedderTest::SetExternalIsolate(m_pIsolate);
30 EmbedderTest::SetUp();
31
32 v8::Isolate::Scope isolate_scope(m_pIsolate);
33 v8::HandleScope handle_scope(m_pIsolate);
34 FXJS_PerIsolateData::SetUp(m_pIsolate);
35 FXJS_InitializeRuntime(m_pIsolate, nullptr, &m_pPersistentContext,
36 &m_StaticObjects);
37 }
38
39 void TearDown() override {
40 FXJS_ReleaseRuntime(m_pIsolate, &m_pPersistentContext, &m_StaticObjects);
41 m_pPersistentContext.Reset();
42 FXJS_Release();
43 EmbedderTest::TearDown();
44 }
45
46 v8::Isolate* isolate() { return m_pIsolate; }
47 v8::Local<v8::Context> GetV8Context() {
48 return m_pPersistentContext.Get(m_pIsolate);
49 }
50
51 private:
52 nonstd::unique_ptr<FXJS_ArrayBufferAllocator> m_pArrayBufferAllocator;
53 v8::Isolate* m_pIsolate;
54 v8::Global<v8::Context> m_pPersistentContext;
55 std::vector<v8::Global<v8::Object>*> m_StaticObjects;
56 };
57
58 TEST_F(FXJSV8Embeddertest, Getters) {
59 v8::Isolate::Scope isolate_scope(isolate()); 17 v8::Isolate::Scope isolate_scope(isolate());
60 v8::HandleScope handle_scope(isolate()); 18 v8::HandleScope handle_scope(isolate());
61 v8::Context::Scope context_scope(GetV8Context()); 19 v8::Context::Scope context_scope(GetV8Context());
62 20
63 FXJSErr error; 21 FXJSErr error;
64 int sts = FXJS_Execute(isolate(), nullptr, kScript, &error); 22 int sts = FXJS_Execute(isolate(), nullptr, kScript, &error);
65 EXPECT_EQ(0, sts); 23 EXPECT_EQ(0, sts);
66 24
67 v8::Local<v8::Object> This = FXJS_GetThisObj(isolate()); 25 v8::Local<v8::Object> This = FXJS_GetThisObj(isolate());
68 v8::Local<v8::Value> fred = FXJS_GetObjectElement(isolate(), This, L"fred"); 26 v8::Local<v8::Value> fred = FXJS_GetObjectElement(isolate(), This, L"fred");
69 EXPECT_TRUE(fred->IsNumber()); 27 EXPECT_TRUE(fred->IsNumber());
70 } 28 }
OLDNEW
« no previous file with comments | « fpdfsdk/src/javascript/public_methods_embeddertest.cpp ('k') | pdfium.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698