Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 1533103003: Fix Android renderer crash related to field trial synchronization. (Closed)

Created:
5 years ago by Alexei Svitkine (slow)
Modified:
5 years ago
Reviewers:
Georges Khalil
CC:
chromium-reviews, asvitkine+watch_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Android renderer crash related to field trial synchronization. This was caused by field trials that were not yet finalized to use their default group name in the state string. Then, when they later are finalized (as a result of code querying them in the browser process, for example), they would update the renderers with their new state and cause an inconsistency to be detected. This issue was introduced by the following CL which changed all trials to be sent to renderers: https://codereview.chromium.org/700953002 This CL fixes the issue by finalizing all trials when their state is serialized to be given to the renderer command line. BUG=359406 Committed: https://crrev.com/ce540da188fb277e1deab0a349c83a91d9a0c5c0 Cr-Commit-Position: refs/heads/master@{#366405}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -13 lines) Patch
M base/metrics/field_trial.h View 1 chunk +1 line, -1 line 0 comments Download
M base/metrics/field_trial.cc View 1 chunk +3 lines, -7 lines 0 comments Download
M base/metrics/field_trial_unittest.cc View 2 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Alexei Svitkine (slow)
5 years ago (2015-12-18 22:27:22 UTC) #2
Georges Khalil
lgtm
5 years ago (2015-12-21 16:22:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1533103003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1533103003/1
5 years ago (2015-12-21 16:23:33 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-21 17:34:01 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-21 17:35:11 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ce540da188fb277e1deab0a349c83a91d9a0c5c0
Cr-Commit-Position: refs/heads/master@{#366405}

Powered by Google App Engine
This is Rietveld 408576698