Issue 15331002: Implement ObservedArrayPop, ObservedArrayShift, ObservedArrayUnshift & ObservedArraySplice

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15331002: Implement ObservedArrayPop, ObservedArrayShift, ObservedArrayUnshift & ObservedArraySplice (Closed)

Created:
7 years, 7 months ago by rafaelw

Modified:
7 years, 6 months ago

Reviewers:
arv (Not doing code reviews), adamk, rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Implement ObservedArrayPop, ObservedArrayShift, ObservedArrayUnshift & ObservedArraySplice R=rossberg,adamk,arv BUG= Committed: http://code.google.com/p/v8/source/detail?r=14846

Patch Set 2 : remove stray file #

Total comments: 1

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+207 lines, -50 lines)			Patch
	M	src/array.js	View		10 chunks	+143 lines, -34 lines	1 comment	Download
	M	test/mjsunit/harmony/object-observe.js	View		3 chunks	+64 lines, -16 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

adamk

lgtm https://codereview.chromium.org/15331002/diff/2001/src/array.js File src/array.js (right): https://codereview.chromium.org/15331002/diff/2001/src/array.js#newcode750 src/array.js:750: function ObservedArraySplice(start, delete_count) { Sad to see splice ...

7 years, 7 months ago (2013-05-20 17:51:50 UTC) #2

rossberg

7 years, 6 months ago (2013-05-28 11:16:09 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r14846 (presubmit successful).

Expand Messages | Collapse Messages

Issue 15331002: Implement ObservedArrayPop, ObservedArrayShift, ObservedArrayUnshift & ObservedArraySplice (Closed)

Description

Patch Set 1 #

Patch Set 2 : remove stray file #

Messages