Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 1533073003: PPC: [es6] Correct Function.prototype.apply, Reflect.construct and Reflect.apply. (Closed)

Created:
5 years ago by MTBrandyberry
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [es6] Correct Function.prototype.apply, Reflect.construct and Reflect.apply. Port 5bd4832492e66b79b19a45653abc68bef3cd6cb4 Original commit message: Introduce a new Apply builtin that forms a correct and optimizable foundation for the Function.prototype.apply, Reflect.construct and Reflect.apply builtins (which properly does the PrepareForTailCall as required by the ES2015 spec). The new Apply builtin avoids going to the runtime if it is safe to just access the backing store elements of the argArray, i.e. if you pass a JSArray with no holes, or an unmapped, unmodified sloppy or strict arguments object. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:4413, v8:4430 LOG=n Committed: https://crrev.com/36afb789e655070c5a4b67cc286339397fdb84ed Cr-Commit-Position: refs/heads/master@{#32974}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+308 lines, -151 lines) Patch
M src/ppc/builtins-ppc.cc View 2 chunks +308 lines, -151 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
MTBrandyberry
5 years ago (2015-12-18 16:38:09 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1533073003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1533073003/1
5 years ago (2015-12-18 16:38:12 UTC) #3
JoranSiu
lgtm
5 years ago (2015-12-18 17:39:51 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-18 18:33:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1533073003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1533073003/1
5 years ago (2015-12-18 19:14:22 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-18 19:17:08 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-18 19:18:03 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/36afb789e655070c5a4b67cc286339397fdb84ed
Cr-Commit-Position: refs/heads/master@{#32974}

Powered by Google App Engine
This is Rietveld 408576698