Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 1533063002: Adding/Removing same class multiple times schedules same invalidation set. (Closed)

Created:
5 years ago by ramya.v
Modified:
5 years ago
Reviewers:
esprehn, Eric Willigers
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, do_not_use, Timothy Loh
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding/Removing same class multiple times schedules same invalidation set. Avoided scheduling same invalidation set if it already exists in pending invalidations vector. BUG=403252 Committed: https://crrev.com/cb526e637d1f69e898a833f58eec9a59745250bf Cr-Commit-Position: refs/heads/master@{#366343}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Updating as per review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp View 1 2 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
ramya.v
PTAL! Thanks
5 years ago (2015-12-18 10:09:37 UTC) #2
esprehn
Seems legit, lgtm. One comment about style. https://codereview.chromium.org/1533063002/diff/1/third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp File third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp (right): https://codereview.chromium.org/1533063002/diff/1/third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp#newcode73 third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp:73: if (!pendingInvalidations.siblings().contains(invalidationSet)) ...
5 years ago (2015-12-19 03:34:23 UTC) #3
ramya.v
Updated the nits as per review comments. PTAL! Thanks https://codereview.chromium.org/1533063002/diff/1/third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp File third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp (right): https://codereview.chromium.org/1533063002/diff/1/third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp#newcode73 third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp:73: ...
5 years ago (2015-12-21 03:31:57 UTC) #4
Eric Willigers
lgtm
5 years ago (2015-12-21 04:24:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1533063002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1533063002/20001
5 years ago (2015-12-21 04:25:01 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/152362)
5 years ago (2015-12-21 05:34:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1533063002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1533063002/20001
5 years ago (2015-12-21 07:00:17 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-21 07:03:58 UTC) #15
commit-bot: I haz the power
5 years ago (2015-12-21 07:05:03 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cb526e637d1f69e898a833f58eec9a59745250bf
Cr-Commit-Position: refs/heads/master@{#366343}

Powered by Google App Engine
This is Rietveld 408576698