Adding/Removing same class multiple times schedules same invalidation set.

Adding/Removing same class multiple times schedules same invalidation set.

Avoided scheduling same invalidation set if it already exists in
pending invalidations vector.

BUG=403252
Committed: https://crrev.com/cb526e637d1f69e898a833f58eec9a59745250bf
Cr-Commit-Position: refs/heads/master@{#366343}

[ramya.v, 2015-12-18 10:09:36]

ramya.v@samsung.com changed reviewers:
+ ericwilligers@chromium.org, esprehn@chromium.org

[ramya.v, 2015-12-18 10:09:37]

PTAL!

Thanks

[esprehn, 2015-12-19 03:34:23]

Seems legit, lgtm. One comment about style.

https://codereview.chromium.org/1533063002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp
(right):

https://codereview.chromium.org/1533063002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp:73: if
(!pendingInvalidations.siblings().contains(invalidationSet))
ditto

https://codereview.chromium.org/1533063002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp:83: if
(!invalidationSet->isEmpty()) {
you might write:

if (invalidationSet->isEmpty())
  continue;

instead to avoid needing to indent the loop body so much.

[ramya.v, 2015-12-21 03:31:57]

Updated the nits as per review comments. PTAL!

Thanks

https://codereview.chromium.org/1533063002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp
(right):

https://codereview.chromium.org/1533063002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp:73: if
(!pendingInvalidations.siblings().contains(invalidationSet))
On 2015/12/19 03:34:23, esprehn wrote:
> ditto

Done.

https://codereview.chromium.org/1533063002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp:83: if
(!invalidationSet->isEmpty()) {
On 2015/12/19 03:34:23, esprehn wrote:
> you might write:
> 
> if (invalidationSet->isEmpty())
>   continue;
> 
> instead to avoid needing to indent the loop body so much.

Done.

[Eric Willigers, 2015-12-21 04:24:44]

The CQ bit was checked by ericwilligers@chromium.org

[Eric Willigers, 2015-12-21 04:24:44]

lgtm

[Eric Willigers, 2015-12-21 04:24:45]

The patchset sent to the CQ was uploaded after l-g-t-m from esprehn@chromium.org
Link to the patchset: https://codereview.chromium.org/1533063002/#ps20001
(title: "Updating as per review comments")

[commit-bot: I haz the power, 2015-12-21 04:25:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1533063002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1533063002/20001

[commit-bot: I haz the power, 2015-12-21 05:34:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-21 05:34:12]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[ramya.v, 2015-12-21 06:33:12]

Patchset #3 (id:40001) has been deleted

[ramya.v, 2015-12-21 07:00:01]

The CQ bit was checked by ramya.v@samsung.com

[ramya.v, 2015-12-21 07:00:01]

The patchset sent to the CQ was uploaded after l-g-t-m from esprehn@chromium.org
Link to the patchset: https://codereview.chromium.org/1533063002/#ps20001
(title: "Updating as per review comments")

[commit-bot: I haz the power, 2015-12-21 07:00:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1533063002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1533063002/20001

[commit-bot: I haz the power, 2015-12-21 07:03:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-21 07:05:02]

Description was changed from

==========
Adding/Removing same class multiple times schedules same invalidation set.

Avoided scheduling same invalidation set if it already exists in
pending invalidations vector.

BUG=403252
==========

to

==========
Adding/Removing same class multiple times schedules same invalidation set.

Avoided scheduling same invalidation set if it already exists in
pending invalidations vector.

BUG=403252

Committed: https://crrev.com/cb526e637d1f69e898a833f58eec9a59745250bf
Cr-Commit-Position: refs/heads/master@{#366343}
==========

[commit-bot: I haz the power, 2015-12-21 07:05:03]

Patchset 2 (id:??) landed as
https://crrev.com/cb526e637d1f69e898a833f58eec9a59745250bf
Cr-Commit-Position: refs/heads/master@{#366343}