Make SkMatrix::get*Scale[s]() fail on NaN

Make SkMatrix::get*Scale[s]() fail on NaN

BUG=skia:4718
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1532963002

Committed: https://skia.googlesource.com/skia/+/ef2c7c705748e4c563c468f667dae7a9a38ffabc

[bsalomon, 2015-12-17 20:53:27]

Description was changed from

==========
Make SkMatrix::get*Scale[s]() fail on NaN

BUG=skia:4718
==========

to

==========
Make SkMatrix::get*Scale[s]() fail on NaN

BUG=skia:4718
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2015-12-17 20:54:21]

bsalomon@google.com changed reviewers:
+ reed@google.com

[reed1, 2015-12-17 21:04:26]

lets hurry and try to make these methods private!

lgtm

https://codereview.chromium.org/1532963002/diff/20001/include/core/SkMatrix.h
File include/core/SkMatrix.h (right):

https://codereview.chromium.org/1532963002/diff/20001/include/core/SkMatrix.h...
include/core/SkMatrix.h:657: * values of scaleFactors[] are undefined.
consider adding SK_WARN_UNUSED_RESULT ?

[bsalomon, 2015-12-17 23:18:19]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2015-12-17 23:18:19]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1532963002/#ps40001
(title: "Add SK_WARN_UNUSED_RESULT")

[commit-bot: I haz the power, 2015-12-17 23:18:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1532963002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1532963002/40001

[commit-bot: I haz the power, 2015-12-17 23:33:17]

Description was changed from

==========
Make SkMatrix::get*Scale[s]() fail on NaN

BUG=skia:4718
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Make SkMatrix::get*Scale[s]() fail on NaN

BUG=skia:4718
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/ef2c7c705748e4c563c468f667dae7a9a38ffabc
==========

[commit-bot: I haz the power, 2015-12-17 23:33:20]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/ef2c7c705748e4c563c468f667dae7a9a38ffabc